Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.6] Fix warnings with attrs 19.2 and fix object assertions (#5902) #5944

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Conversation

mimi1vx
Copy link
Contributor

@mimi1vx mimi1vx commented Oct 11, 2019

No description provided.

@mimi1vx mimi1vx changed the title Fix warnings with attrs 19.2 and fix object assertions (#5902) [4.6] Fix warnings with attrs 19.2 and fix object assertions (#5902) Oct 11, 2019
Fix warnings with attrs 19.2 and fix object assertions
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #5944 into 4.6-maintenance will increase coverage by 0.27%.
The diff coverage is 83.33%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           4.6-maintenance   #5944      +/-   ##
==================================================
+ Coverage            95.92%   96.2%   +0.27%     
==================================================
  Files                  115     115              
  Lines                26553   26560       +7     
  Branches              2615    2616       +1     
==================================================
+ Hits                 25472   25551      +79     
+ Misses                 755     703      -52     
+ Partials               326     306      -20
Impacted Files Coverage Δ
testing/test_assertion.py 97.67% <100%> (ø) ⬆️
src/_pytest/assertion/util.py 98.16% <100%> (ø) ⬆️
src/_pytest/mark/structures.py 92.77% <100%> (+0.04%) ⬆️
src/_pytest/compat.py 96.05% <66.66%> (+2.08%) ⬆️
src/_pytest/fixtures.py 97.55% <0%> (+0.27%) ⬆️
testing/test_capture.py 99.25% <0%> (+0.29%) ⬆️
testing/test_terminal.py 99.84% <0%> (+0.31%) ⬆️
testing/test_config.py 99.83% <0%> (+0.32%) ⬆️
testing/test_pdb.py 99.22% <0%> (+0.38%) ⬆️
src/_pytest/pytester.py 91.66% <0%> (+0.42%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2d87dc...c03e46f. Read the comment docs.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mimi1vx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants