REF: Multithread safe CRS

[snowman2]

• Part of REF: Making pyproj completely threadsafe #782
• Tests added
• Fully documented, including history.rst for all changes and api/*.rst for new API

[codecov]

Codecov Report

Merging #793 (13983f0) into master (6412a04) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   94.69%   94.98%   +0.28%     
==========================================
  Files          21       21              
  Lines        1528     1595      +67     
==========================================
+ Hits         1447     1515      +68     
+ Misses         81       80       -1     

Impacted Files	Coverage Δ
pyproj/transformer.py	95.36% <ø> (ø)
pyproj/crs/crs.py	97.44% <100.00%> (+0.74%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6412a04...c945258. Read the comment docs.

[jorisvandenbossche]

Cool! Will try to give this a go tomorrow

[jorisvandenbossche]

This looks good!

As mentioned in geopandas/dask-geopandas#36, locally this fixed the decoding errors we see with dask-geopandas.

Maybe one suggestion: if you want to limit the duplication of the docstrings (because now all the attributes/methods that needed to be added to dispatch to self._crs have a copy of the docstring), I think it should be relatively easy to use a decorator that automatically adds the docstring of the cython class.

Something like

def inherit_doc():
    """
    A decorator adding the docstring from the equivalent `_CRS` method.
    """

    def decorator(decorated):
        original_method = getattr(_CRS, decorated.__name__, None)
        if original_method:
            doc = original_method.__doc__ or ""
        else:
            doc = ""

        decorated.__doc__ = doc
        return decorated

    return decorator

[snowman2]

Thanks for testing! I am going to merge now and deal with the docstring later. It is something that I agree should be looked into.