CI: move CI to GHA

[martinfleis]

Closes #35

I have removed python 3.6 and added 3.9, which is run on Linux, windows and mac. Dev env uses master of geopandas, pygeos and dask.

It should also start using codecov for coverage.

[martinfleis]

Oh, yeah. It won't activate until merged since there's no GHA workflow yet.

[jorisvandenbossche]

identation is off here?

[martinfleis]

good catch, fixed

[jorisvandenbossche]

Let's test it in master

[martinfleis]

Well, the good news is that CI seems to work. The bad that it fails.

[jorisvandenbossche]

It's strange, it's the same test that is failing as on travis, but with a different error ...

[jorisvandenbossche]

But now it seems as something we should be able to solve

[jorisvandenbossche]

It might be a change in pyproj. If I update pyproj to the latest 3.0.1, then I can reproduce the error.

But given it's a strange decoding error, that might be the thread-safety issue that came up recently.

[jorisvandenbossche]

Very short term "solution" might be to pin pyproj to an older version in our CI to get that green again.

A more proper short term solution might be to ensure that each partition gets a copy of the CRS, while now we set the same CRS object on each geopandas geodataframe (which are accessed from different threads):

dask-geopandas/dask_geopandas/core.py

Lines 155 to 157 in 6fd01e5

	def set_crs(self, value):
	"""Set the value of the crs on a new object"""
	return self.map_partitions(_set_crs, value, enforce_metadata=False)

dask-geopandas/dask_geopandas/core.py

Lines 15 to 19 in 6fd01e5

	def _set_crs(df, crs):
	"""Return a new object with crs set to ``crs``"""
	df = df.copy(deep=False)
	df.crs = crs
	return df

Eventually this will be fixed in pyproj as well. @snowman2 just opened a PR for that!

[snowman2]

This is likely the issue: pyproj4/pyproj#589

I would be surprised if there is an older version of pyproj that worked. The issue appears to be kind of random.

You could test out this fix: pyproj4/pyproj#793

[jorisvandenbossche]

You could test out this fix: pyproj4/pyproj#793

That's what I was planning. And indeed, with pyproj master I can reproduce the failure, with that branch it's fixed!