Add text about making notification bar dismissable #3500
Conversation
| @@ -33,6 +33,30 @@ | |||
| - dismissable: Indicates notification be be dismissed. Defaults to hidden. | |||
There was a problem hiding this comment.
could we fix this typo at the same time "be be" should be "can be"
| @@ -33,6 +33,30 @@ | |||
| - dismissable: Indicates notification be be dismissed. Defaults to hidden. | |||
| - visible: Indicates a visible, non-dismissed notification | |||
| */ | |||
| /* | |||
| A notification bar can be made dismissable by adding the following to the main | |||
There was a problem hiding this comment.
I think the placement of this is fine, however, I think you can include it in the same comment block :)
| /* | ||
| A notification bar can be made dismissable by adding the following to the main | ||
| notification-bar div: | ||
| - .notification-bar--dismissable to it's classes |
There was a problem hiding this comment.
"it's" should be "its" https://data.grammarbook.com/blog/pronouns/1-grammar-error/
| notification-bar div: | ||
| - .notification-bar--dismissable to it's classes | ||
| - data-controller="notification" | ||
| - data-target="notification.notification" as attributes |
| - data-target="notification.notification" as attributes | ||
|
|
||
| The data-controller and data-target are used for handling visibility, | ||
| including, adding .notification-bar--visible to notification-bar div if it has |
There was a problem hiding this comment.
no need for , after "including"
pgadige
force-pushed
the
notification-help-text
branch
from
23320f5 to
c6862a1
Compare
|
Thank you @nlhkabu for your valuable feedback. I've made the required changes. Please let me know of any suggestions after you've reviewed. |
|
Looks good to me @pgadige ! One small thing I picked up when reading it again - |
pgadige
changed the title
|
Looks good to me too @pgadige 👍 |
|
Thanks @aalmazan and @pgadige! If either/both of you would like to work on one of these, please comment there to let us know:
|
Fixes #3379
Add help text to explain how to make a notification bar dismissable.