Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination for Project History #2921

Closed
di opened this issue Feb 12, 2018 · 4 comments
Closed

Pagination for Project History #2921

di opened this issue Feb 12, 2018 · 4 comments
Labels
help needed We'd love volunteers to advise on or help fix/implement this. HTML requires change to HTML files javascript requires change to JavaScript files UX/UI design, user experience, user interface
Milestone
Cool but not urgent

Comments

@di
Copy link
Member

di commented Feb 12, 2018

Per #2911: Currently the 'Project History' page just lists all the journal entries for a project, but this could be quite long. We should add pagination for this page.
@di di added this to the Cool but not urgent milestone Feb 12, 2018
@di di mentioned this issue Feb 12, 2018
Merged
@brainwane brainwane mentioned this issue Feb 26, 2018
Merged
@brainwane brainwane added UX/UI design, user experience, user interface javascript requires change to JavaScript files HTML requires change to HTML files Post launch - medium priority help needed We'd love volunteers to advise on or help fix/implement this. and removed Post launch - medium priority labels Mar 14, 2018
@brainwane brainwane mentioned this issue Apr 3, 2018
Merged
@brainwane brainwane mentioned this issue Mar 22, 2019
Closed
@cand126
Copy link
Contributor

cand126 commented Mar 24, 2019 •
edited
Loading

Hi @di, I would like to ask some questions.

  1. Is there a mockup for pagination?
  2. Should I add pagination support in all_versions() in models.py?

@di
Copy link
Member Author

di commented Mar 25, 2019

@cand126 Thanks for the questions. This is specifically about the "Project History" in the logged-in UI for project maintainers, it looks like this:

Screen Shot 2019-03-25 at 11 13 30 AM

Screen Shot 2019-03-25 at 11 13 35 AM

The pagination buttons are there, but they don't work, and it looks like right now the results are getting truncated as well. This might just require hooking the pagination query parameter up to the query for the Journal entries.

@cand126
Copy link
Contributor

cand126 commented Mar 29, 2019

@di I created a package with lots of realeases, and the pagination feature seems fine. Each page has 25 items, and the I can navigate to different pages by click the button. The url also indicates the page number.
Screenshot from 2019-03-29 23-54-19
Screenshot from 2019-03-29 23-54-24
Screenshot from 2019-03-29 23-54-30

@di
Copy link
Member Author

di commented Mar 29, 2019

Sorry for the goose chase @cand126. I realized that this was due to a misconfiguration of our CDN, which was stripping out URL parameters for these pages. I just updated and it's now fixed.

Thanks for helping debug!

@di di closed this as completed Mar 29, 2019
@di di mentioned this issue May 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help needed We'd love volunteers to advise on or help fix/implement this. HTML requires change to HTML files javascript requires change to JavaScript files UX/UI design, user experience, user interface
Projects
None yet
Milestone
Cool but not urgent
Development

No branches or pull requests
3 participants
@di @brainwane @cand126