-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new 'path' type, for filesystem paths. #981
Conversation
Allows to properly handle ~user expansion for all paths.
"""optparse.Option subclass handling 'path' type. | ||
|
||
See: http://docs.python.org/2/library/optparse#adding-new-types""" | ||
TYPES = optparse.Option + ('path',) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be optparse.Option.TYPES + ('path',)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, fixed in a later commit.
Good point by jezdez.
I haven't looked into the option system much, so I can't comment really |
Hey, is there still interest in this? |
@rbarrois sure :) |
Accidentally closed this, reopening. Sorry! |
Hello! As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged. If this pull request is still valid, please rebase it against If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:
|
This Pull Request was closed because it cannot be automatically reparented to the Please feel free to re-open it or re-submit it if it is still valid and you have rebased it onto |
Allows to properly handle ~user expansion for all paths.
See issue #980.