Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize paths starting with ~ in find-links #2455

Merged
merged 3 commits into from
Mar 7, 2015
Merged

Normalize paths starting with ~ in find-links #2455

merged 3 commits into from
Mar 7, 2015

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Feb 24, 2015

No description provided.

@pfmoore pfmoore mentioned this pull request Feb 24, 2015
Closed
xavfernandez
xavfernandez reviewed Feb 24, 2015
View reviewed changes
pip/index.py
# blindly normalize anything starting with a ~...
self.find_links = []
for link in find_links:
if link.startswith('~'):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should maybe also accept "file://~/som_path" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My instinct says no, ~/foo is a path and should be subject to typical path expansions. But file://~/foo is a URL, and ~-expansion isn't part of the URL spec.

msabramo
msabramo reviewed Mar 7, 2015
View reviewed changes
pip/index.py
self.find_links = []
for link in find_links:
if link.startswith('~'):
new_link = normalize_path(link)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to import normalize_path. See pfmoore#1

@pfmoore
Merge pull request #1 from msabramo/pr2455_tweak_1
eaac580 
pip/index.py: Add import of normalize_path
pfmoore added a commit that referenced this pull request Mar 7, 2015
@pfmoore
Merge pull request #2455 from pfmoore/normalize_findlinks
98df838 
Normalize paths starting with ~ in find-links
@pfmoore pfmoore merged commit 98df838 into pypa:develop Mar 7, 2015
This was referenced Mar 7, 2015
Merged
Closed
msabramo added a commit to msabramo/pip that referenced this pull request Mar 11, 2015
@msabramo
Add test_finder.test_tilde unit test
886f38e 
Adds a `test_tilde` test to augment @pfmoore's work in
pypa#2455 ("Normalize paths starting with ~
in find-links")

This would've caught the missing import problem we had
(pfmoore#1).
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2019
@pfmoore pfmoore deleted the normalize_findlinks branch January 24, 2021 11:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pfmoore @msabramo @xavfernandez