Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain why version cannot be retrieved when Requires-Python is not satisfied #9708

Merged
merged 9 commits into from
Mar 10, 2022

Conversation

ronaudinho
Copy link
Contributor

resolves #9615.

since logs for links skipped when Requires-Python is not satisfied are suppressed anyway, I decided to utilize those. the resulting error message changed a bit from my comment in the mentioned issue.

src/pip/_internal/index/package_finder.py Outdated Show resolved Hide resolved
src/pip/_internal/index/package_finder.py Outdated Show resolved Hide resolved
src/pip/_internal/index/package_finder.py Outdated Show resolved Hide resolved
@xavfernandez
Copy link
Member

Hello, could you paste the updated output from this PR ?

@uranusjr uranusjr added this to the 21.1 milestone Apr 13, 2021
@sbidoul sbidoul closed this Apr 17, 2021
@sbidoul sbidoul reopened this Apr 17, 2021
@sbidoul
Copy link
Member

sbidoul commented Apr 17, 2021

@xavfernandez this is how it looks like

image

@sbidoul
Copy link
Member

sbidoul commented Apr 17, 2021

From the example above I find the displayed message somewhat confusing. The first message says "Could not find a version..." and second says "Found versions that...". But strictly speaking, both are lists of versions that were found. They were ignored for different reasons.

Would it make sense to display the second message (with the list of skipped versions) first, and phrase it with something such as Ignored the following versions that require a different python version: ...) ?

@sbidoul
Copy link
Member

sbidoul commented Apr 20, 2021

@ronaudinho do you think you could do the requested change in the next day or so ? So this can go in 21.1.

@sbidoul sbidoul modified the milestones: 21.1, 21.2 Apr 23, 2021
@uranusjr
Copy link
Member

@ronaudinho Ping on this since we’ll be working on the 21.2 release soon. This can be included if you could address the comment above and rebase the commit against latest main.

@uranusjr uranusjr removed this from the 21.2 milestone Jul 24, 2021
@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Aug 15, 2021
@pradyunsg
Copy link
Member

@ronaudinho Would it be possible for you to update this PR?

@pradyunsg pradyunsg added the S: awaiting response Waiting for a response/more information label Sep 18, 2021
@ronaudinho
Copy link
Contributor Author

@uranusjr @pradyunsg sorry for the lack of reply, I'll update the PR with @sbidoul 's suggestion in a day or two.

@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 10, 2022
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably do a refactoring to make the "Requires-Python" in reason check more structured, but this change is a good enhancement as-is.

src/pip/_internal/index/package_finder.py Outdated Show resolved Hide resolved
@uranusjr
Copy link
Member

p.s. I merged main to resolve conflicts, so if anyone plans to push more changes, please pull first.

@uranusjr uranusjr removed the S: awaiting response Waiting for a response/more information label Mar 10, 2022
@pradyunsg pradyunsg merged commit c679319 into pypa:main Mar 10, 2022
@pradyunsg
Copy link
Member

Thanks @ronaudinho for this, and everyone else for the discussion + work on this! ^.^

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain why version cannot be retrieved due to python-requires
6 participants