More structured link evaluation result #10956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
skip news
A new enum class is implemented for the link evaluator to use instead of a simple boolean to better distinguish between various evaluation errors. This allows the caller to better distinguish error sources with a structured check instead of fragile error string comparison.
uranusjr
force-pushed
the
evaluate-link-error-refactor
branch
from
407983f
to
d61b539
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up refactoring to #9708.
A new enum class is implemented for the link evaluator to use instead of a simple boolean to better distinguish between various evaluation errors. This allows the caller to better distinguish error sources with a structured check instead of fragile error string comparison.