Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make proxy parameter override environment proxy #11091

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Conversation

q0w
Copy link
Contributor

@q0w q0w commented May 6, 2022

@q0w

This comment was marked as outdated.

@q0w q0w marked this pull request as draft May 6, 2022 04:25
@q0w q0w marked this pull request as ready for review May 31, 2022 08:44
@q0w q0w closed this Jun 14, 2022
@q0w q0w reopened this Jun 14, 2022
@q0w q0w force-pushed the override-proxy branch 2 times, most recently from 04003b0 to 19f7535 Compare June 14, 2022 20:12
@q0w
Copy link
Contributor Author

q0w commented Jul 13, 2022

@pradyunsg I think, it would also fix #5378

Copy link

@abhinavsingh abhinavsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for proxy.py related changes. 👍

@EFord36
Copy link

EFord36 commented Nov 29, 2023

Hi,

I see this has been approved for a long time, but not merged. Is there a reason this is blocked from merging?

Of course I understand the authors of pip are busy and have a lot to deal with, just wanted to check in case this had got stuck just before the finish line and could be helped over, or if the reason is needing a rebase or something, whether I could help get it over the line.

(I discovered this via the issue it closes, #10685, as resolving this issue would be of considerable help to me).

@uranusjr uranusjr merged commit 7c49d06 into pypa:main Apr 3, 2024
25 checks passed
@q0w q0w deleted the override-proxy branch April 12, 2024 17:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--proxy should override environment variables
4 participants