-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make proxy parameter override environment proxy #11091
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
04003b0
to
19f7535
Compare
@pradyunsg I think, it would also fix #5378 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for proxy.py
related changes. 👍
Hi, I see this has been approved for a long time, but not merged. Is there a reason this is blocked from merging? Of course I understand the authors of pip are busy and have a lot to deal with, just wanted to check in case this had got stuck just before the finish line and could be helped over, or if the reason is needing a rebase or something, whether I could help get it over the line. (I discovered this via the issue it closes, #10685, as resolving this issue would be of considerable help to me). |
Closes #10685
ref: https://requests.readthedocs.io/en/latest/api/#requests.Session.trust_env