Make proxy parameter override environment proxy #10691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Nov 29, 2021
Co-authored-by: Tzu-ping Chung <[email protected]>
1 task
|
Hmm... this is a change in a vendored library (specifically: https://github.com/psf/requests/). We don't modify our vendored libraries to change their behaviours (https://pip.pypa.io/en/stable/development/vendoring-policy/). The modified class, specifically, does handle getting the proxy from self.proxies later (around line 710), so this might not be the correct fix upstream either. None the less, I'd recommend filing a PR against the requests project for fixing this -- a fix that we will pull in for the pip release that's made after requests fixes this. :) |
|
Closed by #11091 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #10685. It makes the "--proxy" parameter take precedence over environment variables.