Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an explicit warning on parsing git version failure #10419

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Added an explicit warning on parsing git version failure #10419

merged 1 commit into from
Sep 21, 2021

Conversation

fspv
Copy link
Contributor

@fspv fspv commented Sep 1, 2021 •
edited
Loading

There is not enough visibility in case we fail to parse a git version. Adding an explicit logging here to facilitate debug should the parsing fail.

This addresses #10361

uranusjr
uranusjr reviewed Sep 2, 2021
View reviewed changes
news/10361.trivial.rst Outdated Show resolved Hide resolved
src/pip/_internal/vcs/git.py Outdated Show resolved Hide resolved
@uranusjr uranusjr added this to the 21.3 milestone Sep 5, 2021
@pradyunsg pradyunsg merged commit 2ef2b0d into pypa:main Sep 21, 2021
@pradyunsg
Copy link
Member

pradyunsg commented Sep 21, 2021 •
edited
Loading

Thanks @prius! ^.^

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fspv @pradyunsg @uranusjr