Log a warning when git's version can't be parsed

[pradyunsg]

Would it make sense to have a logger.debug (or logger.info/warning) call here mentioning that the version couldn't be parsed ?

Originally posted by @xavfernandez in #10117 (comment)

Yes, let's do a warning. :)

[josix]

Hello @uranusjr, @pradyunsg this issue looks suitable for new contributor like me. May I take a try for resolving this issue? Thanks.

[uranusjr]

Please fee free :)

[aniketh-varma]

Hello, I would like to work on this issue. I would be grateful if you can please guide me on fixing this as well.

[uranusjr]

@aniketh-varma Feel free! You’d want to follow instructions to set up a development environment, change the code in git.py, and add a test for the error message.

[HausCloud]

@uranusjr Is there a way to change what git --version outputs during a test?

[uranusjr]

Does subprocess not work?

[uranusjr]

But you should not need to get the actual git --version output. The goal should be to test whether an invalid Git version triggers a warning, but git --version is not guaranteed to be invalid (or valid), so a test should not be written against it. You should use mocking instead.

[HausCloud]

@uranusjr Thanks for help. I've made a pull request.

[Shivansh-007]

Hi, Looks like this issue has already been resolved by #10419, though there were no tests introduced for this enhancement.

[pradyunsg]

Ah, I see! Would you be willing to file a PR for adding a test?

[Shivansh-007]

Yeah sure, will do 👍🏻

[Hermit97]

Hello, is this issue still open?

[DiddiLeija]

Hey @Hermit97, thanks for offering. There is already a PR to close this at #10801.