Error handling upon uninstall invalid parameter
#10171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested changes
Jul 22, 2021
GuyTuval
force-pushed
the
handle_invalid_uninstall_parameters_4958
branch
from
4eef092
to
4625015
Compare
uranusjr
approved these changes
Jul 22, 2021
|
Can we close #4958 after this or should we keep it open for some other things? |
|
Hmm... I think we'd want to wait until we change this to an error for that? |
uranusjr
reviewed
Jul 23, 2021
uranusjr
approved these changes
Jul 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented error handling when passing an invalid paramer to
pip uninstall