Skip to content

Commit

Permalink
Implemented logging when passing an invalid parameter to `pip uninsta…
Browse files Browse the repository at this point in the history
…ll`.
  • Loading branch information
GuyTuval committed Jul 22, 2021
1 parent 76cd70a commit 4625015
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 0 deletions.
1 change: 1 addition & 0 deletions news/4958.feature.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a warning when passing an invalid requirement to ``pip uninstall``.
11 changes: 11 additions & 0 deletions src/pip/_internal/commands/uninstall.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import logging
from optparse import Values
from typing import List

Expand All @@ -15,6 +16,9 @@
from pip._internal.utils.misc import protect_pip_from_modification_on_windows


logger = logging.getLogger(__name__)


class UninstallCommand(Command, SessionCommandMixin):
"""
Uninstall packages.
Expand Down Expand Up @@ -60,6 +64,13 @@ def run(self, options, args):
)
if req.name:
reqs_to_uninstall[canonicalize_name(req.name)] = req
else:
logger.warning(
"Invalid requirement: %r ignored -"
" the uninstall command expects named"
" requirements.",
name,
)
for filename in options.requirements:
for parsed_req in parse_requirements(
filename,
Expand Down
12 changes: 12 additions & 0 deletions tests/functional/test_uninstall.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,18 @@ def test_basic_uninstall_with_scripts(script):
)


@pytest.mark.parametrize("name",
["GTrolls.tar.gz",
"https://guyto.com/archives/"])
def test_uninstall_invalid_parameter(script, caplog, name):
result = script.pip("uninstall", name, "-y", expect_error=True)
expected_message = (
f"Invalid requirement: '{name}' ignored -"
f" the uninstall command expects named requirements."
)
assert expected_message in result.stderr


@pytest.mark.network
def test_uninstall_easy_install_after_import(script):
"""
Expand Down

0 comments on commit 4625015

Please sign in to comment.