MacOS producing wheel for 10.9 even though 11.0 is specified

[tonybaloney]

Description

I'm trying to produce universal2, x64 and arm64 wheels for macOS 11+.

The extension module specifically requires 11.0+ and would fail in older versions of Mac.

I've tried setting MACOSX_DEPLOYMENT_TARGET=11.0 after looking at the source code. There's nothing in the documentation how to change the deployment target for the wheels to be 11.0 instead of 10.9

In spite of this, CI produces the file -

pyjion-1.2.0-cp310-cp310-macosx_10_9_universal2.whl

The build workflow is -

name: Build

on: [push, pull_request]

jobs:
  build_wheels:
    name: Build wheels on ${{ matrix.os }}
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        os: [macos-latest]

    steps:
      - uses: actions/checkout@v2
        with:
          submodules: 'recursive'

      - name: Build wheels
        uses: pypa/[email protected]
        env:
          CIBW_ARCHS_MACOS: "x86_64 universal2 arm64"
          CIBW_BEFORE_BUILD_MACOS: "bash eng/install-dotnet.sh --version 6.0.100"
          CIBW_ENVIRONMENT_MACOS: MACOSX_DEPLOYMENT_TARGET=11.0

      - uses: actions/upload-artifact@v2
        with:
          path: ./wheelhouse/*.whl

pyproject.toml

[build-system]
requires = ["setuptools", "wheel", "scikit-build", "cmake", "ninja"]

[tool.cibuildwheel.macos]
before-build = "bash eng/install-dotnet.sh --version 6.0.100"
environment = {MACOSX_DEPLOYMENT_TARGET=11.0}
repair-wheel-command = ""
archs = ["x86_64", "universal2"]

Build log

No response

CI config

No response

[joerick]

I'm no expert, but if your build is using cmake, you might have better luck with CMAKE_OSX_DEPLOYMENT_TARGET. Can't find a relevant discussion on this but I'm sure it has come up previously....! @henryiii might have more ideas from the scikit-build side.

[henryiii]

I bet this is a reverse manifestation of scikit-build/scikit-build#596 & #818, which might be fixed by scikit-build/scikit-build#607

[tonybaloney]

@henryiii I raised it here because if I do setup.py bdist_wheel it creates the 11.0 version

[henryiii]

cibuildwheel sets _PYTHON_HOST_PLATFORM to something containing 10.9 regardless of MACOSX_DEPLOYMENT_TARGET (see #819), however this was considered scikit-build's fault for blindly accepting this since setuptoools still computes the macOS version even if it's wrong here.

[henryiii]

Could you see if using scikit-build/scikit-build#607 fixes it?

[joerick]

Closed due to inactivity. Feel free to reopen if you have more info.

[henryiii]

Yeah, this should have been fixed in a released version of Scikit-build.