-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPI updating strategy #581
Comments
Yes the new wheels will be very small. It should be done within a few weeks. |
ok - do you need pypi admin access @cookpa ? |
I think I have to be an owner to change things, yes. Whatever I am now lets me see the project under my project, but I can only view. |
you got it |
@cookpa can we try to build wheels now and see the size? When I build locally using |
Windows is failing because it explicitly calls setup.py, let's see if the others build |
@ncullen93 I got the Linux wheels to build, the artifacts are named funny but I can fix that. I installed the python 3.10 Linux wheel and it runs sucessfully! Amazing that it's only 17Mb |
On Intel Mac, there is a problem with cibuildwheel, it is getting into trouble with the MACOSX_DEPLOYMENT_TARGET. I think it might relate to this known issue with scikit-build Bumping the version of scikit-build and / or cibuildwheel might help |
Yeah I see the small size is also replicated on the ci build. Hoping it is for real. I will try to fix the wheel issues. |
I'm hoping that setting I may also have to downgrade cibuildwheel to 2.16.2 again, because the latest version appears to break the package delocalization on arm64. |
Wheels are looking good, they fall over occasionally but mostly seem to build. It's been a long time since a release made it to PyPI, it would be good to get a new one up. To do:
One option would be to leave one wheel per platform of 0.3.8 for now (which?) |
Sure, thanks Phil.On Aug 5, 2024, at 6:56 PM, Philip Cook ***@***.***> wrote:
image.png (view on web)
image.png (view on web)
Most recent pypi stats. Mostly Linux, less older python now. I could clean up some 0.3.8 packages and try a new release if it's OK with everyone
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Deleted 0.3.8, figure we may as well make more space and not deal with this again for longer. I'm ready to tag v0.5.3. Do I need to do anything else before releasing? I presume after I tag, I should edit |
It worked! But the workflow only sends Linux wheels. Is there some other mechanism to upload the other platforms? |
yes - it's via
you need to add some stuff to |
OK thanks I will try it out |
I uploaded a source dist, which works, and a bunch of wheels from the Github build. Annoyingly, pip won't install the wheel for my Mac unless I do
This has long been the case for me with Github wheels. I think I tried to fix this before but will take another look. Hopefully we can get wheels building correctly for the next release |
I was able to make a compatible wheel with
For some reason, my Intel Mac only lists 10_X as compatible targets, even though I have Mac OS 14. We might therefore want to change the wheels to target an earlier version, currently they target the runner OS (12 for Intel, 14 for ARM). My next to-do will be to try building wheels for an earlier OS target. |
#697 I documented these Mac issues and set the wheel workflow to push everything to PyPI. I cannot get the GHA workflow to allow an earlier I only added a python 3.11 wheel by hand, but can add others if needed. |
As discussed in #578 and #580
From @ncullen93:
I don't have permission to delete old wheels. I am not attached to building every python, I don't know if there's stats on which versions get downloaded the most but will look into it.
What do others (devs and users) think about building fewer wheels?
The text was updated successfully, but these errors were encountered: