Fixing some problem MULTIPROCESS_SERVER

[pariterre]

This change is 

[Ipuch]

Reviewed 5 of 9 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @pariterre)

---

bioptim/gui/online_callback_server.py line 41 at r2 (raw file):

class _HeaderMessage(StrEnum):

_HeaderResponse ?

---

bioptim/gui/online_callback_server.py line 73 at r2 (raw file):

    @intstaticproperty
    def header_generic_len() -> int:
        return 1024

HEADER_GENERIC_LENGTH = 1024

---

bioptim/gui/online_callback_server.py line 332 at r2 (raw file):

            for phase_times in data_json["dummy_phase_times"]:
                dummy_time_vector.append([DM(v) for v in phase_times])
            del data_json["dummy_phase_times"]

comprehension list

Code quote:

            dummy_time_vector = []
            for phase_times in data_json["dummy_phase_times"]:
                dummy_time_vector.append([DM(v) for v in phase_times])
            del data_json["dummy_phase_times"]

---

bioptim/gui/online_callback_server.py line 480 at r2 (raw file):

        self._host = host if host else _DEFAULT_HOST
        self._port = port if port else _DEFAULT_PORT

initialize with super the object first

Code quote:

        self._host = host if host else _DEFAULT_HOST
        self._port = port if port else _DEFAULT_PORT

---

bioptim/gui/online_callback_server.py line 521 at r2 (raw file):

                    "Could not connect to the plotter server, make sure it is running by calling 'PlottingServer()' on "
                    "another python instance or allowing for automatic start (Linux or Windows) of the server setting "
                    "the online_option to 'OnlineOptim.MULTIPROCESS_SERVER' when instantiating your solver"

.

---

bioptim/gui/online_callback_server.py line 611 at r2 (raw file):

        if (
            self._should_wait_ok_to_client_on_new_data
            and self._socket.recv(_HeaderMessage.header_len).decode() != _HeaderMessage.OK

has_received_OK

---

bioptim/gui/online_callback_server.py line 619 at r2 (raw file):

        if (
            self._should_wait_ok_to_client_on_new_data
            and self._socket.recv(_HeaderMessage.header_len).decode() != _HeaderMessage.OK

Idem

---

bioptim/gui/utils.py line 1 at r2 (raw file):

class strstaticproperty:

"""custom decorators for str"""

---

bioptim/gui/utils.py line 9 at r2 (raw file):

class intstaticproperty:

"""custom decorators for int"""

---

bioptim/interfaces/interface_utils.py line 36 at r2 (raw file):

    online_optim = interface.opts.online_optim.get_default()
    if online_optim == OnlineOptim.MULTIPROCESS:

map_onlineoptim_to_online_callback = {
OnlineOptim.MULTIPROCESS: OnlineCallbackMultiprocess,
OnlineOptim.MULTIPROCESS_SERVER : OnlineCallbackServer,
...,
}

online_callback = map_onlineoptim_to_online_callback.get(online_optim, None)

if online_callback is None:
raise ....

[Ipuch]

Minimal test if needed.

[pariterre]

Reviewable status: 11 of 14 files reviewed, 10 unresolved discussions (waiting on @Ipuch)

---

bioptim/gui/online_callback_server.py line 41 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…

_HeaderResponse ?

_ResponseHeader done
And found a way to do what should have been done previously

---

bioptim/gui/online_callback_server.py line 73 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…

HEADER_GENERIC_LENGTH = 1024

Done.

---

bioptim/gui/online_callback_server.py line 332 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…

comprehension list

This would be a double list comprehension, it is probably clearer to keep it as is

---

bioptim/gui/online_callback_server.py line 480 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…

initialize with super the object first

Done

---

bioptim/gui/online_callback_server.py line 521 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…

.

Done.

---

bioptim/gui/online_callback_server.py line 611 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…

has_received_OK

Done.

---

bioptim/gui/online_callback_server.py line 619 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…

Idem

Done.

---

bioptim/interfaces/interface_utils.py line 36 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…

map_onlineoptim_to_online_callback = {
OnlineOptim.MULTIPROCESS: OnlineCallbackMultiprocess,
OnlineOptim.MULTIPROCESS_SERVER : OnlineCallbackServer,
...,
}

online_callback = map_onlineoptim_to_online_callback.get(online_optim, None)

if online_callback is None:
raise ....

This looks much more confusing to me, while taking more lines, sticking with previous :P

---

bioptim/gui/utils.py line 1 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…

"""custom decorators for str"""

Removed

---

bioptim/gui/utils.py line 9 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…

"""custom decorators for int"""

Removed

[Ipuch]

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @pariterre)