Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] external forces as symbolic variables to allow multi-threading #865

Merged
merged 10 commits into from
Mar 28, 2024

Conversation

EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Mar 28, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request? issues Should external forces be numerical values or states ? #657
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

pariterre
pariterre previously approved these changes Mar 28, 2024
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

pariterre
pariterre previously approved these changes Mar 28, 2024
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.51%. Comparing base (4cda59c) to head (4cc49ef).
Report is 55 commits behind head on master.

Files Patch % Lines
bioptim/dynamics/configure_problem.py 75.00% 2 Missing ⚠️
bioptim/models/biorbd/biorbd_model.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   78.50%   78.51%           
=======================================
  Files         141      141           
  Lines       16309    16296   -13     
=======================================
- Hits        12804    12794   -10     
+ Misses       3505     3502    -3     
Flag Coverage Δ
unittests 78.51% <94.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EveCharbie
Copy link
Collaborator Author

@pariterre can be merged

@EveCharbie EveCharbie changed the title [WIP] external forces as symbolic variables to allow multi-threading [RTM] external forces as symbolic variables to allow multi-threading Mar 28, 2024
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre merged commit 2a354a0 into pyomeca:master Mar 28, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants