Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM when tests pass] Extra checks in holonomic model #854

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Mar 1, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

pariterre
pariterre previously approved these changes Mar 1, 2024
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)


bioptim/models/biorbd/holonomic_biorbd_model.py line 91 at r1 (raw file):

    def check_dependant_jacobian(self):
        q_test = MX.sym("q_test", self.nb_q)

MX.sym? DM? np.zeros?

@pariterre pariterre changed the title [RTR] Extra checks in holonomic model [RTM when tests pass] Extra checks in holonomic model Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.26%. Comparing base (7494252) to head (64d8720).
Report is 48 commits behind head on master.

Files Patch % Lines
bioptim/models/biorbd/holonomic_biorbd_model.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #854   +/-   ##
=======================================
  Coverage   78.25%   78.26%           
=======================================
  Files         139      139           
  Lines       16228    16244   +16     
=======================================
+ Hits        12699    12713   +14     
- Misses       3529     3531    +2     
Flag Coverage Δ
unittests 78.26% <95.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre merged commit eb64845 into pyomeca:master Mar 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants