-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTM after push] Provide two examples of minmax OCP with extra parameters #835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure to understand why pendulum.py was removed though..
Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @mickaelbegon)
bioptim/examples/getting_started/pendulum.py
line 10 at r1 (raw file):
During the optimization process, the graphs are updated real-time (even though it is a bit too fast and short to really appreciate it). Finally, once it finished optimizing, it animates the model using the optimal solution """
Why did you remove pendulum.py?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #835 +/- ##
==========================================
- Coverage 78.39% 78.12% -0.28%
==========================================
Files 140 140
Lines 16081 16100 +19
==========================================
- Hits 12607 12578 -29
- Misses 3474 3522 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mickaelbegon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solve conflicts ... should be ready to merge
Reviewable status: 3 of 5 files reviewed, all discussions resolved (waiting on @pariterre)
bioptim/examples/getting_started/pendulum.py
line 10 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
Why did you remove pendulum.py?
it was my mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mickaelbegon)
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*"
)?Changes to Core Features:
This change is