Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM after push] Provide two examples of minmax OCP with extra parameters #835

Merged
merged 7 commits into from
Feb 9, 2024

Conversation

mickaelbegon
Copy link
Contributor

@mickaelbegon mickaelbegon commented Jan 25, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@mickaelbegon mickaelbegon changed the title Provide two examples of minmax OCP with extra parameters [WIP] Provide two examples of minmax OCP with extra parameters Jan 25, 2024
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand why pendulum.py was removed though..

Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @mickaelbegon)


bioptim/examples/getting_started/pendulum.py line 10 at r1 (raw file):

During the optimization process, the graphs are updated real-time (even though it is a bit too fast and short to really
appreciate it). Finally, once it finished optimizing, it animates the model using the optimal solution
"""

Why did you remove pendulum.py?

@pariterre pariterre changed the title [WIP] Provide two examples of minmax OCP with extra parameters [RTM after push] Provide two examples of minmax OCP with extra parameters Feb 1, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (c02d206) 78.39% compared to head (ae901fd) 78.12%.
Report is 1 commits behind head on master.

Files Patch % Lines
..._ocp/minimize_maximum_torque_by_extra_parameter.py 48.68% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
- Coverage   78.39%   78.12%   -0.28%     
==========================================
  Files         140      140              
  Lines       16081    16100      +19     
==========================================
- Hits        12607    12578      -29     
- Misses       3474     3522      +48     
Flag Coverage Δ
unittests 78.12% <48.68%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pariterre
pariterre previously approved these changes Feb 2, 2024
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@mickaelbegon I see quite a few changes in the main file (minimize and minmax) is this mergeable?

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mickaelbegon)

Copy link
Contributor Author

@mickaelbegon mickaelbegon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solve conflicts ... should be ready to merge

Reviewable status: 3 of 5 files reviewed, all discussions resolved (waiting on @pariterre)


bioptim/examples/getting_started/pendulum.py line 10 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

Why did you remove pendulum.py?

it was my mistake

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mickaelbegon)

@pariterre pariterre merged commit 679b4bd into pyomeca:master Feb 9, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants