Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore example simulation in getting started #823

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Jan 19, 2024

As said in the title


This change is Reviewable

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7043777) 78.72% compared to head (53e60c8) 78.72%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files         140      140           
  Lines       15742    15742           
=======================================
  Hits        12393    12393           
  Misses       3349     3349           
Flag Coverage Δ
unittests 78.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)


bioptim/examples/getting_started/example_simulation.py line 30 at r1 (raw file):

    X = InitialGuessList()
    X["q"] = [0] * 2
    X["qdot"] = [0] * 2

Please use non-capitalized letter

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre merged commit ffbe0b4 into pyomeca:master Feb 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants