Removed save and load

[pariterre]

All Submissions:

• Have you followed the guidelines in our Contributing document [docs/contribution.md]?
• Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
• Have you opened/linked the issue related to your pull request?
• Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
• When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

1. Does your submission pass the tests (if not please explain why this is intended)?
2. Did you write a proper documentation (docstrings and ReadMe)
3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new examples for your core changes, as applicable?
• Have you written new tests for your core changes, as applicable?

---

This change is 

[pariterre]

@Ipuch and @EveCharbie
Are you chill with this? (tests fail only because of transitifon towards biorbd 1.10.2)

[EveCharbie]

Looks perfect to me :)
Maybe we should just update pendulum.py to show how we recommend saving the solution (using the del sol.ocp).

Reviewable status: 0 of 36 files reviewed, 3 unresolved discussions (waiting on @pariterre)

---

bioptim/examples/stochastic_optimal_control/obstacle_avoidance_direct_collocation.py line 187 at r2 (raw file):

    objective_functions.add(ObjectiveFcn.Mayer.MINIMIZE_TIME, weight=1)
    objective_functions.add(
        ObjectiveFcn.Lagrange.MINIMIZE_CONTROL,

If it was possible to let it as before, it would better match the original paper.

Code quote:

     ObjectiveFcn.Lagrange.MINIMIZE_CONTROL,

---

bioptim/models/biorbd/biorbd_model.py line 34 at r2 (raw file):

    @property
    def name(self) -> str:
        # parse the path and split to get the .bioMod name

<3

---

tests/shard5/test_global_stochastic_collocation.py line 215 at r2 (raw file):

    f = np.array(sol.cost)
    np.testing.assert_equal(f.shape, (1, 1))
    np.testing.assert_almost_equal(f[0, 0], 4.099146411209181)

Please revert if you agree with my comment above

[pariterre]

Reviewable status: 0 of 36 files reviewed, 3 unresolved discussions (waiting on @EveCharbie)

---

bioptim/examples/stochastic_optimal_control/obstacle_avoidance_direct_collocation.py line 187 at r2 (raw file):

Previously, EveCharbie (Eve Charbonneau) wrote…

If it was possible to let it as before, it would better match the original paper.

Mayer.MINIMIZE_CONTROL was removed from bioptim in another PR. This is just so the tests pass (because for some reason it was not caught before)

---

bioptim/models/biorbd/biorbd_model.py line 34 at r2 (raw file):

Previously, EveCharbie (Eve Charbonneau) wrote…

<3

Done. <3

---

tests/shard5/test_global_stochastic_collocation.py line 215 at r2 (raw file):

Previously, EveCharbie (Eve Charbonneau) wrote…

Please revert if you agree with my comment above

N/A

[pariterre]

Looks perfect to me :)
Maybe we should just update pendulum.py to show how we recommend saving the solution (using the del sol.ocp).

I think some of the examples already do that, but more importantly, it looks messy when save and load is showcased... In order not to scare the beginning users, I think we should not add it in pendulum...

This is just using the normal way to save and load data in Python anyway

[pariterre]

This is not already included