Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTR] Solving a critical issue of codeclimate #788

Merged
merged 2 commits into from
Nov 2, 2023
Merged

[RTR] Solving a critical issue of codeclimate #788

merged 2 commits into from
Nov 2, 2023

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Oct 31, 2023 •
edited by pariterre
Loading

This change is Reviewable

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
bioptim/interfaces/solver_options.py 84.44% <100.00%> (+0.18%) ⬆️

📢 Thoughts on this report? Let us know!.

pariterre
pariterre approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Was was this a "critical" ?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@Ipuch
Copy link
Collaborator Author

Ipuch commented Oct 31, 2023 •
edited by pariterre
Loading

:lgtm:

Was was this a "critical" ?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

Apparently
https://codeclimate.com/github/pyomeca/bioptim/issues?severity%5B%5D=critical&status%5B%5D=&status%5B%5D=open&status%5B%5D=confirmed

@Ipuch Ipuch mentioned this pull request Nov 1, 2023
Merged
11 tasks
@pariterre pariterre merged commit dc69b4c into pyomeca:master Nov 2, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pariterre pariterre pariterre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ipuch @pariterre