[RTR] Try to refactor a bit the initialisation of Solution

[Ipuch]

This change is 

[codecov]

Codecov Report

Attention: 174 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
bioptim/dynamics/integrator.py	95.97% <100.00%> (ø)
...amples/getting_started/example_variable_scaling.py	75.00% <ø> (ø)
bioptim/interfaces/stochastic_bio_model.py	52.94% <100.00%> (ø)
bioptim/limits/penalty.py	83.53% <100.00%> (ø)
bioptim/limits/penalty_option.py	83.04% <100.00%> (+0.04%)	⬆️
...ptim/optimization/receding_horizon_optimization.py	95.98% <100.00%> (ø)
bioptim/dynamics/dynamics_functions.py	84.29% <0.00%> (ø)
bioptim/interfaces/stochastic_biorbd_model.py	32.35% <33.33%> (ø)
bioptim/dynamics/ode_solver.py	85.20% <81.81%> (ø)
bioptim/optimization/optimal_control_program.py	85.95% <89.47%> (ø)
... and 4 more

📢 Thoughts on this report? Let us know!.

[pariterre]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Ipuch)

---

bioptim/optimization/solution.py line 504 at r1 (raw file):

                self._states["unscaled"],
                self._controls["unscaled"],
                [self.parameters for _ in range(self.ocp.n_phases)],  # artificially duplicate to use it in every phase

I do not understand the necessity of that nor that I think that it is a good idea?

---

bioptim/optimization/solution.py line 616 at r1 (raw file):

                self._states["unscaled"],
                self._controls["unscaled"],
                [self.parameters for _ in range(self.ocp.n_phases)],  # artificially duplicate to use it in every phase

I do not understand the necessity of that nor that I think that it is a good idea?

---

bioptim/optimization/solution.py line 649 at r1 (raw file):

                self._states["unscaled"],
                self._controls["unscaled"],
                [self.parameters for _ in range(self.ocp.n_phases)],  # artificially duplicate to use it in every phase

I do not understand the necessity of that nor that I think that it is a good idea?

[Ipuch]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pariterre)

---

bioptim/optimization/solution.py line 504 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

I do not understand the necessity of that nor that I think that it is a good idea?

Done.

---

bioptim/optimization/solution.py line 616 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

I do not understand the necessity of that nor that I think that it is a good idea?

Done.

---

bioptim/optimization/solution.py line 649 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

I do not understand the necessity of that nor that I think that it is a good idea?

Done.

[pariterre]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

The merge-base changed after approval.