-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTM] Bug and BoundsList #703
Conversation
68597aa
to
28893ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @20chupin)
bioptim/limits/path_conditions.py
line 654 at r1 (raw file):
f"bounds['{item}'] is ambiguous because there are multiple phases. " f"To access the boundaries in this case, you should write bounds[phase]['{item}'] instead of " f"bounds['{item}']. I you didn't mean to use multiple phases, you may have specified bounds['{item}'] "
If
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)
bioptim/limits/path_conditions.py
line 654 at r1 (raw file):
Previously, Ipuch (Pierre Puchaud) wrote…
If
Done.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #703 +/- ##
=======================================
Coverage 80.95% 80.95%
=======================================
Files 119 119
Lines 13571 13571
=======================================
Hits 10986 10986
Misses 2585 2585
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @20chupin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @20chupin)
bioptim/limits/path_conditions.py
line 651 at r2 (raw file):
if isinstance(item, str) and len(self.options) > 1: raise TypeError(
This should appear in the parent using "self.type" to get the type of option, and this should also be in the setter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Ipuch and @pariterre)
bioptim/limits/path_conditions.py
line 651 at r2 (raw file):
Previously, pariterre (Pariterre) wrote…
This should appear in the parent using "self.type" to get the type of option, and this should also be in the
setter
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests?
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @20chupin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They passed !
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @20chupin)
Corrects a bug when running
getting_started\pendulum.py
and check the bound is not defined twice or with the same nameThis change is