Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding savepath for qBittorrent client #8304

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Adding savepath for qBittorrent client #8304

merged 2 commits into from
Aug 11, 2020

Conversation

Gabisonfire
Copy link
Contributor

@Gabisonfire Gabisonfire commented Aug 7, 2020

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@Gabisonfire
Copy link
Contributor Author

Gabisonfire commented Aug 7, 2020

Sorry @p0psicles , I'm not good at git :) I don't know what happened with my last commit, but I redid it. Let me know if anything else needs to be changed. Thank you

@Gabisonfire
Copy link
Contributor Author

Anything missing for this merge?

@p0psicles
Copy link
Contributor

I'll check today

@p0psicles
Copy link
Contributor

p0psicles commented Aug 11, 2020

Few things.

  1. Pls run (yarn dev in folder themes-default/slim) and commit changes
  2. can you add the message, that it only works with version 3.2.0?
    Like:
<config-template v-show="clientsConfig.torrent[clients.torrents.method].pathOption" label-for="torrent_client" label="Downloaded files location">
                                                <file-browser name="torrent_path" title="Select downloaded files location" :initial-dir="clients.torrents.path" @update="clients.torrents.path = $event" />
                                                <p>where <span id="torrent_client" v-if="clientsConfig.torrent[clients.torrents.method]">{{clientsConfig.torrent[clients.torrents.method].shortTitle || clientsConfig.torrent[clients.torrents.method].title}}</span> will save downloaded files (blank for client default)
                                                    <span v-show="clients.torrents.method === 'downloadstation'"> <b>Note:</b> the destination has to be a shared folder for Synology DS</span>
                                                </p>
                                                <span v-show="clients.torrents.method === 'qbittorrent'">
                                                    <p><b>Note:</b> for qBitTorrent 3.2.0 and up</p>
                                                </span>
                                            </config-template>

@Gabisonfire
Copy link
Contributor Author

Done, thanks for you help

@p0psicles p0psicles merged commit fe70be4 into pymedusa:develop Aug 11, 2020
@Gabisonfire Gabisonfire deleted the develop branch August 11, 2020 23:46
@p0psicles p0psicles added this to the 0.4.0 milestone Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants