Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to set savepath for qBittorrent #8300

Closed
wants to merge 0 commits into from
Closed

Adding option to set savepath for qBittorrent #8300

wants to merge 0 commits into from

Conversation

Gabisonfire
Copy link
Contributor

@Gabisonfire Gabisonfire commented Aug 6, 2020

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@Gabisonfire
Copy link
Contributor Author

Gabisonfire commented Aug 6, 2020

First time I'm working with yarn and js, not sure If I was supposed to commit the js/css files as well

@p0psicles
Copy link
Contributor

p0psicles commented Aug 6, 2020

No. You should only make changes in themes-default. Then use yarn dev.

You, can run yarn dev --watch during development

@medariox
Copy link
Contributor

medariox commented Aug 6, 2020

You should also check if it is a folder with os.path.isdir().

@sharkykh
Copy link
Contributor

sharkykh commented Aug 6, 2020

Just FYI...
It seems that support for this has only been added in qBT 3.2.0 (command/upload) and qBT 3.3.1 (command/download).

@Gabisonfire
Copy link
Contributor Author

@p0psicles Thanks, will do. Should I close this request and do another one at this point?

@medariox That won't work since the path cannot be verified on the client host.

@sharkykh Thanks, I'll add a note like the other settings that are 3.2 +

@p0psicles
Copy link
Contributor

If you can revert the changes in this pr. Also fine with me

@p0psicles
Copy link
Contributor

I think you changed more then intended?

@Gabisonfire Gabisonfire closed this Aug 7, 2020
@Gabisonfire
Copy link
Contributor Author

#8304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants