Fix for an reintroduced bug: Failed to send torrent to qBittorrent if theres an accent in the file name (#4218) #7533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… theres an accent in the file name (#4218)
|
Sorry about that (it was my branch) and thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an fix for an bug that was fixed in #4219 and then reintroduced in #7040
The problem happens when there's an torrent with accents in file name, it will not be sent to qbittorrent, as already discussed in the pull request #4219 the filename in the api call is not necessary (tested again in v2 and still work without it) and cause it to fail when there's accents.