-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/qbittorrent api v2 #7040
Conversation
@sharkykh i tested this with a recent qbittorrent docker conainer. Seems to work fine. Anything I should be aware of? |
Sorry, I don't remember what didn't work for me 15 months ago... |
@@ -2,7 +2,7 @@ | |||
|
|||
"""qBittorrent Client.""" | |||
|
|||
from __future__ import unicode_literals | |||
from __future__ import division, unicode_literals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wrong, division
is not needed in this case, as it's only for the normal division (/
) operator, and does not affect modulo (%
).
Co-Authored-By: sharkykh <[email protected]>
Co-Authored-By: sharkykh <[email protected]>
FYI I tested the latest qbittorrent associated with this issue and it works as expected.
The only warning that shows up is a notification that qbitorrent doesn't support move completed downloads to another directory which given the way that qbittorrent works, IMO, is perfectly fine (this should be done either via custom script or by changing the torrent label after download is complete like Sonarr does). Anyway the meat and potatoes works like a charm. thanks! |
Will try to review tomorrow. |
Implement #6505