Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/qbittorrent api v2 #7040

Merged
merged 11 commits into from
Aug 13, 2019
Merged

Feature/qbittorrent api v2 #7040

merged 11 commits into from
Aug 13, 2019

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Aug 7, 2019

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Implement #6505

@p0psicles
Copy link
Contributor Author

@sharkykh i tested this with a recent qbittorrent docker conainer. Seems to work fine. Anything I should be aware of?

@sharkykh
Copy link
Contributor

sharkykh commented Aug 8, 2019

Sorry, I don't remember what didn't work for me 15 months ago...

@@ -2,7 +2,7 @@

"""qBittorrent Client."""

from __future__ import unicode_literals
from __future__ import division, unicode_literals
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong, division is not needed in this case, as it's only for the normal division (/) operator, and does not affect modulo (%).

medusa/clients/torrent/qbittorrent.py Outdated Show resolved Hide resolved
medusa/clients/torrent/qbittorrent.py Outdated Show resolved Hide resolved
@hferreira23
Copy link

FYI I tested the latest qbittorrent associated with this issue and it works as expected.

2019-08-11 02:01:38 WARNING TORNADO :: [74c3f12] Your client doesn't support moving torrents to new location 2019-08-11 02:01:38 INFO TORNADO :: [74c3f12] Successfully processed. 2019-08-11 02:01:38 INFO TORNADO :: [74c3f12] Processing succeeded for /media/plex/downloads/medusa_postpro/WWE.205.Live.2019.08.06.1080p.WEB.h264-HEEL.mp4 2019-08-11 02:01:36 INFO TORNADO :: [74c3f12] Selected poster for series 323420 (score=4.25, score_bay=7.5, rating=10, votes=1, res=680x1000): https://www.thetvdb.com/banners/posters/323420-1.jpg 2019-08-11 02:01:36 INFO TORNADO :: [74c3f12] Selected fanart for series 323420 (score=4.58523929560476, score_bay=7.17047859120952, rating=10, votes=2, res=1920x1080): https://www.thetvdb.com/banners/fanart/original/323420-3.jpg 2019-08-11 02:01:29 INFO TORNADO :: [74c3f12] Trying to clean any empty folder under /media/plex/Wrestling/WWE 205 Live 2019-08-11 02:01:29 INFO TORNADO :: [74c3f12] This download is marked a priority download so I'm going to replace an existing file if I find one 2019-08-11 02:01:29 INFO TORNADO :: [74c3f12] New file is the same size. 2019-08-11 02:01:29 INFO TORNADO :: [74c3f12] New size: 1.91 GB 2019-08-11 02:01:29 INFO TORNADO :: [74c3f12] Old size: 1.91 GB 2019-08-11 02:01:29 INFO TORNADO :: [74c3f12] New file: /media/plex/downloads/medusa_postpro/WWE.205.Live.2019.08.06.1080p.WEB.h264-HEEL.mp4 2019-08-11 02:01:29 INFO TORNADO :: [74c3f12] Old file: /media/plex/Wrestling/WWE 205 Live/WWE.205.Live.2019-08-06.August.6.2019.1080p_WEB.HEEL.mp4 2019-08-11 02:01:28 INFO TORNADO :: [74c3f12] Processing /media/plex/downloads/medusa_postpro/WWE.205.Live.2019.08.06.1080p.WEB.h264-HEEL.mp4 2019-08-11 02:00:09 INFO SHOWUPDATER :: [74c3f12] Completed but there was nothing to update 2019-08-11 02:00:00 INFO SHOWUPDATER :: [74c3f12] Started periodic show updates 2019-08-11 02:00:00 INFO SHOWUPDATER :: [74c3f12] Finished processing 3097 scene exceptions. 2019-08-11 02:00:00 INFO SHOWUPDATER :: [74c3f12] Updating exception_cache and exception_season_cache 2019-08-11 01:58:09 INFO SNATCHQUEUE-SNATCH-323420 :: [74c3f12] Downloading WWE.205.Live.2019.08.06.1080p.WEB.h264-HEEL with 1 seeders and 1 leechers and size 1.91 GB from NZBHydra2 - Torrents, through a SearchType.MANUAL_SEARCH search 2019-08-11 01:58:09 INFO SNATCHQUEUE-SNATCH-323420 :: [74c3f12] Beginning to snatch release: WWE.205.Live.2019.08.06.1080p.WEB.h264-HEEL

The only warning that shows up is a notification that qbitorrent doesn't support move completed downloads to another directory which given the way that qbittorrent works, IMO, is perfectly fine (this should be done either via custom script or by changing the torrent label after download is complete like Sonarr does).

Anyway the meat and potatoes works like a charm. thanks!

@p0psicles
Copy link
Contributor Author

@medariox?

@medariox
Copy link
Contributor

Will try to review tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants