Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file_size property to Episode, separate it from location. Fixes #… #5961

Closed
wants to merge 3 commits into from
Closed

Add file_size property to Episode, separate it from location. Fixes #… #5961

wants to merge 3 commits into from

Conversation

medariox
Copy link
Contributor

@medariox medariox commented Jan 5, 2019

…5960

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@ghost
Copy link

ghost commented Jan 5, 2019

DeepCode analyzed this pull request.
There are no new issues.

@medariox medariox added Bug Enhancement Concluded Needs review Needs testing Requires testing to make sure it's working as intended labels Jan 5, 2019
@medariox medariox added this to the 0.3.0 milestone Jan 5, 2019
@medariox medariox mentioned this pull request Jan 5, 2019
Closed
@medariox medariox added In progress and removed Bug labels Jan 5, 2019
medariox
medariox commented Jan 5, 2019
View reviewed changes
medusa/tv/episode.py

@file_size.setter
def file_size(self, size=None):
if size is not None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to allow the optional size? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm also curious in which situations where we do have a file, but don't have a size?

@medariox medariox modified the milestones: 0.3.0, 0.3.1 Jan 11, 2019
@p0psicles
Copy link
Contributor

@medariox Can we have this merged first #5795

@p0psicles
Copy link
Contributor

I think we should do a merge develop to be sure

@medariox medariox modified the milestones: 0.3.1, 0.3.2 Mar 20, 2019
@sharkykh sharkykh modified the milestones: 0.3.2, 0.3.3 Jun 5, 2019
@sharkykh sharkykh modified the milestones: 0.3.3, backlog Jun 12, 2019
@p0psicles
Copy link
Contributor

@medariox what's the status of this?

@medariox
Copy link
Contributor Author

Closing this in favor of #7102

@medariox medariox closed this Aug 31, 2019
@medariox medariox deleted the feature/add-file-size-property branch August 31, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles left review comments

Assignees
No one assigned
Labels
Enhancement In progress Needs review Needs testing Requires testing to make sure it's working as intended
Projects
None yet
Milestone
backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@medariox @p0psicles @sharkykh