Fixed changing location for show. #5795
Conversation
p0psicles
commented
Nov 28, 2018
•
p0psicles
commented
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read the contribution guide
|
DeepCode analyzed this pull request. Click to see more details. |
medusa/tv/series.py
Outdated
| @@ -1681,6 +1716,7 @@ def delete_show(self, full=False): | |||
| # remove entire show folder | |||
| if full: | |||
| try: | |||
| _ = self.validate_location # Let's get the exception out of the way asap. | |||
There was a problem hiding this comment.
I don't understand the need of this line.
There was a problem hiding this comment.
self.location does now by default all kind of checks on the filesystem. So if we use it in the apiv2, it will also do those checks there. In stead of having the option to just get the self.location (without any checks) and one optional that does the validations.
There was a problem hiding this comment.
ow wait, this line.. Pff i have to dig for that
| @@ -1681,6 +1716,7 @@ def delete_show(self, full=False): | |||
| # remove entire show folder | |||
| if full: | |||
| try: | |||
| _ = self.validate_location # Let's get the exception out of the way asap. | |||
| log.info(u'{id}: Attempt to {action} show folder {location}', | |||
There was a problem hiding this comment.
Okay, see how here self.location was included in the log. Which previously meant, that this could raise an exception. Just from the info log.
link 1701 self.location was also used. Another place where the exception could have been raised. self.location is now (what was previously self.raw_location), i'm using self.location where it makes sense. But to keep the possibiliy the exception is raised, i put it in line 1719
There was a problem hiding this comment.
I see what you are going for now.
|
DeepCode analyzed this pull request. |
