Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI changes #5692

Merged
merged 8 commits into from
Nov 11, 2018
Merged

Minor UI changes #5692

merged 8 commits into from
Nov 11, 2018

Conversation

sharkykh
Copy link
Contributor

@sharkykh sharkykh commented Nov 11, 2018

I don't think a changelog is needed for any of the changes.

SelectList component

AppHeader component

  • Move topMenu to router.js: This makes the topMenu reactive - now works correctly when navigating between VueRouter routes.

AppLink component

  • Fix active router-link cursor (cherry-picked from Feature/vueify backuprestore #5556)
  • Fix "idle" router-link cursor - the router-link-active only applies to currently matched routes, this fixes the non-active router-links.
  • Update snapshots due to app-link changes

viewlogs.mako & errorlogs.mako

  • Fix Vue errors on log routes - {{PROPER|REPACK|REAL|RERIP}} was causing issues because Vue was trying to parse it.
    For example:
    2018-11-11 14:57:33 DEBUG FINDPROPERS :: [Rarbg] :: [1bb8cd0] Search string: Blindspot S04E05 {{PROPER|REPACK|REAL|RERIP}}

Misc changes

  • flake8: medusa/server/web/home/handler.py

@sharkykh sharkykh added this to the 0.2.12 milestone Nov 11, 2018
@ghost
Copy link

ghost commented Nov 11, 2018

DeepCode analyzed this pull request.
There are no new issues.1 info report was fixed.

Click to see more details.

`{{PROPER|REPACK|REAL|RERIP}}` was causing issues because Vue was trying to parse it.
@sharkykh sharkykh force-pushed the feature/minor-changes branch from ce51a85 to c174a0c Compare November 11, 2018 18:03
Copy link
Collaborator

@OmgImAlexis OmgImAlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medariox medariox merged commit 13456bf into develop Nov 11, 2018
@medariox medariox deleted the feature/minor-changes branch November 11, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants