Post Processing config saving select-list values incorrectly
#5165
Conversation
sharkykh
added
Bug
Concluded
Needs review
Changelog
|
Alright, made the changes to do this in backend. This is actually better since |
| @@ -95,6 +95,34 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def fix_incorrect_list_values(data): | |||
There was a problem hiding this comment.
I would put a method in medusa/config.py.
And just fix it for the suspected fields there.
Then call the method from main somewhere here:
https://github.com/pymedusa/Medusa/blob/release/hotfix-0.2.10/medusa/__main__.py#L1119
That way we don't clutter __main__.py more then necessary?
There was a problem hiding this comment.
I thought since we are removing this in a future version it would be best to put it all in one place?
There was a problem hiding this comment.
It's technically not a config migration. But it's easy to reuse the self.config_obj property. So maybe just add a function there named fix_config() ?
There was a problem hiding this comment.
Yeah it's really good either way
* Fix config-post-processing * Add failing tests for select-list * Fix Lint * Update changelog * Move fix to backend
Fixes #5155
The tests for
select-listare how they should be, however the components needs to be changed to allow for them to pass, and it cannot be changed without changing the usages of it, which will cause an infinite loop at the moment...