Convert Post Processing Config to VueRouter #4946
Conversation
sharkykh
changed the title
sharkykh
changed the title
sharkykh
force-pushed
the
vueify/config-post-processing-sfc
branch
2 times, most recently
from
5033344 to
9152e2c
Compare
sharkykh
added
Concluded
Needs testing
|
Still need to test this a bit more to make sure I didn't break anything, but it looks good so far. |
Stub all the components used
`Config patch ignored {u'postProcessing': {u'showDownloadDir': None}}`
sharkykh
force-pushed
the
vueify/config-post-processing-sfc
branch
from
8220eb8 to
cefe4bf
Compare
| Database:␊ | ||
| <span>44.11</span></td></tr><tr><td><i class="icon16-config-python"></i> Python Version:</td><td></td></tr><tr><td><i class="icon16-config-ssl"></i> SSL Version:</td><td></td></tr><tr><td><i class="icon16-config-os"></i> OS:</td><td></td></tr><tr><td><i class="icon16-config-locale"></i> Locale:</td><td></td></tr><tr><td> </td><td> </td></tr><tr class="infoTableSeperator"><td> </td><td> </td></tr><tr><td><i class="icon16-config-user"></i> User:</td><td></td></tr><tr><td><i class="icon16-config-dir"></i> Program Folder:</td><td></td></tr><tr><td><i class="icon16-config-config"></i> Config File:</td><td></td></tr><tr><td><i class="icon16-config-db"></i> Database File:</td><td></td></tr><tr><td><i class="icon16-config-cache"></i> Cache Folder:</td><td></td></tr><tr><td><i class="icon16-config-log"></i> Log Folder:</td><td></td></tr><tr><td><i class="icon16-config-arguments"></i> Arguments:</td><td><pre>[␊ | ||
| "--nolaunch",␊ | ||
| "--datadir=C:\\\\Medusa\\\\Data"␊ |
There was a problem hiding this comment.
Unsure if it's related to this PR but what's up with the 4 backslashes?
There was a problem hiding this comment.
I copied the values from the Vuex tab on devtools, it doubles everything. I'll fix that.
There was a problem hiding this comment.
Actually, looks like the original value is correct.
It might be the prettyPrintJSON method...
| Database:␊ | ||
| <span>44.11</span></td></tr><tr><td><i class="icon16-config-python"></i> Python Version:</td><td>2.7.15 (v2.7.15:ca079a3ea3, Apr 30 2018, 16:30:26) [MSC v.1500 64 bit (AMD64)]</td></tr><tr><td><i class="icon16-config-ssl"></i> SSL Version:</td><td></td></tr><tr><td><i class="icon16-config-os"></i> OS:</td><td></td></tr><tr><td><i class="icon16-config-locale"></i> Locale:</td><td></td></tr><tr><td> </td><td> </td></tr><tr class="infoTableSeperator"><td> </td><td> </td></tr><tr><td><i class="icon16-config-user"></i> User:</td><td></td></tr><tr><td><i class="icon16-config-dir"></i> Program Folder:</td><td></td></tr><tr><td><i class="icon16-config-config"></i> Config File:</td><td></td></tr><tr><td><i class="icon16-config-db"></i> Database File:</td><td></td></tr><tr><td><i class="icon16-config-cache"></i> Cache Folder:</td><td></td></tr><tr><td><i class="icon16-config-log"></i> Log Folder:</td><td></td></tr><tr><td><i class="icon16-config-arguments"></i> Arguments:</td><td><pre>[␊ | ||
| "--nolaunch",␊ | ||
| "--datadir=C:\\\\Medusa\\\\Data"␊ |
There was a problem hiding this comment.
@sharkykh didn't you fix this?
There was a problem hiding this comment.
I did not. The "problem" here is the response from the API is correct (C:\Medusa\Data), then when applying JSON.stringify on it, it escapes the backslashes and each \ becomes \\ and that is what is printed. The snapshot simply escapes it again, and that's why it's 4 backslashes for each original backslash.
I believe the original Python version of this page used json.dumps which would produce the same result, so I figured it's correct. 🤔
There was a problem hiding this comment.
No worries, just wanted to make sure in the case you had fixed it that it hadn't snuck back in.
OmgImAlexis
removed
Needs review
Needs testing
config.vuerender test/config/postProcessingto SFCconfig-post-processing.vueThe page is throwing warnings in the tests due to a bug invue/vue-test-utils.Fixed upstream: "Cannot read property '_transitionClasses' of undefined" when injecting vee-validate which is not used vuejs/vue-test-utils#829
I stubbed the components for now...