Vueify config-postprocessing #4259

p0psicles · 2018-05-27T20:51:56Z

PR is based on the DEVELOP branch
Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
Read the contribution guide

Depends on:

Todo:

OmgImAlexis · 2018-05-28T07:27:59Z

themes-default/slim/views/vue-components/name-pattern.mako

@@ -0,0 +1,378 @@
+<script type="text/x-template" id="name-pattern-tempate">
+    <div id="name_pattern_wrapper">
+


Was this extra line intentional?

OmgImAlexis · 2018-05-28T07:28:37Z

themes-default/slim/views/vue-components/name-pattern.mako

+                            </label>
+                        </div>
+                        <div id="naming_key" class="nocheck" v-if="showLegend">
+                                <table class="Key">


This should be using 2 spaces like the rest of the HTML.

Ive used 4 spaces for all now.

Ah, this is 8 I think, double indented?

OmgImAlexis · 2018-05-28T07:30:16Z

themes-default/slim/views/vue-components/name-pattern.mako

+            }
+        },
+        mounted() {
+            this.namingPattern = this.pattern;


Please switch to this.

const { pattern } = this; this.namingPattern = pattern;

You could also add namingPattern and presets here so you're not setting anything directly to this.*.

But why? You go from one line to two lines of code. What is the benefit of this?

Just the same reason you'd use a const anywhere else.

If you use this. you can still set it to another value which is wrong since you should be using the store or local data. If you're using a const there's no issue there and it makes it more clear that you're import read-only data.

…eify-postprocessing

OmgImAlexis · 2018-05-30T08:08:49Z

themes-default/slim/views/config_postProcessing.mako

@@ -290,16 +309,16 @@ const startVue = () => {
                        <fieldset class="component-group-list">

                            <!-- default name-pattern component -->
-                            <name-pattern :pattern="pattern" :presets="presets"></name-pattern>
+                            <name-pattern :enabled="true" :naming-pattern="pattern" :naming-presets="presets" :multi-ep-style="multiEpSelected" :multi-ep-styles="multiEpStrings" @change="onChangePattern" ></name-pattern>


Since this is the default why not move this data to the components data object as default values?

Prob merge conflict.

…eify-postprocessing # Conflicts: # medusa/server/api/v2/config.py # themes-default/slim/views/config_postProcessing.mako # themes-default/slim/views/layouts/main.mako # themes/dark/templates/config_postProcessing.mako # themes/dark/templates/layouts/main.mako # themes/light/templates/config_postProcessing.mako # themes/light/templates/layouts/main.mako

… component. Moved mako python to apiv2 / vue. Started bootstrapping the postprocessing page.

OmgImAlexis · 2018-06-18T14:57:27Z

themes/dark/templates/config_postProcessing.mako

-                                    <span class="component-title">Metadata Type:</span>
-                                    <span class="component-desc">
+                                    <span>Metadata Type:</span>
+                                    <span >


Missed a space here.

sharkykh · 2018-06-23T21:13:02Z

medusa/server/api/v2/config.py

@@ -92,6 +92,19 @@ def get(self, identifier, path_param=None):

            for section in config_sections:
                config_data[section] = DataGenerator.get_data(section)
+        config_data['postProcessing'] = NonEmptyDict()


@p0psicles Don't forget to move these down to the DataGenerator class below.

OmgImAlexis · 2018-06-24T15:11:41Z

@p0psicles any chance this could make it into the next release?

p0psicles · 2018-06-24T16:39:20Z

I think 0.2.7 is realistic
Most of the work will be migrating meta data tab

* Extend config items.

p0psicles · 2018-07-29T11:54:38Z

Hmm that should not have made any difference in snapshot

sharkykh · 2018-07-29T12:01:15Z

I think I made some changes and didn't update snapshots, sorry.

p0psicles · 2018-07-29T12:05:53Z

But your changes still build. After my commit it errored?

sharkykh · 2018-07-29T12:28:38Z

@p0psicles
You're right.
The diff is this block not longer shows up:

        <div class="form-group row">
            <h3 class="col-sm-12">Multi-EP sample:</h3>
            <div class="example col-sm-12">
                <span id="naming_example_multi" class="jumbo"></span>
            </div>
        </div>

p0psicles · 2018-07-29T12:33:42Z

Waaat.. I checked that after i made the change. Hmm. Maybe it was still cached

p0psicles · 2018-07-29T12:34:12Z

Happy to see the snapshot test is doing its work

…o make api calls. * Update the snapshots.

p0psicles · 2018-07-29T19:29:25Z

I had to do allot more testing on the name-pattern. And fixed some small bugs. It's still not perfect. But working and not making too many api calls. @sharkykh can you do a final check?

…ages that have not been made responsive yet.

…al post processing settings. * Only show/hide scheduled pp settings with the "scheduled postprocessor" toggle. * used the same bs classes for all the tabs. * Reduced the min-height for component-group class to 100px * Made tab metadata responsive.

OmgImAlexis · 2018-07-31T11:17:41Z

themes-default/slim/views/config_postProcessing.mako

                                    <p>Settings that dictate how Medusa should process completed downloads.</p>
+                                    <p>The scheduled postprocessor while periodically scan a folder for media to process.</p>


Replace "while" with "will".

* Hide the name-pattern legend, when changing from custom pattern to preset.

p0psicles · 2018-07-31T20:37:14Z

Sorry, i have no idea why the backend test is failing?

p0psicles · 2018-07-31T22:55:35Z

Ok great. With one more approval this can be merged.

Moved over files from search templates pr.

730e36f

OmgImAlexis reviewed May 28, 2018

View reviewed changes

p0psicles added 5 commits May 30, 2018 08:58

Renamed some of the postProcessing naming variabls in api/v2/config.py

caa609e

Added full name-pattern support to postProcessing.

60075c2

Merge remote-tracking branch 'remotes/origin/develop' into feature/vu…

bde8190

…eify-postprocessing

Add covert to namespace main.mako.

3bcf911

Update examples when switching multi ep style.

68b041c

OmgImAlexis reviewed May 30, 2018

View reviewed changes

p0psicles changed the title ~~Moved over files from search templates pr.~~ Vueify config-postprocessing May 30, 2018

p0psicles added the In progress label May 30, 2018

p0psicles mentioned this pull request Jun 8, 2018

Vueify config #4055

Merged

OmgImAlexis mentioned this pull request Jun 8, 2018

Vueify #4058

Open

p0psicles added 6 commits June 18, 2018 11:02

make the 'enabled' property for name-pattern default true.

ea75a25

Remove the saved-message component. As that's not used anymore.

31221ad

Prob merge conflict.

Moved convert method to inc_defs.mako

383a57a

Moved all checkboxes for the post processing tab to the toggle-button…

6edf0cc

… component. Moved mako python to apiv2 / vue. Started bootstrapping the postprocessing page.

Migrated the rest of the post-processing tab.

d7e0460

OmgImAlexis reviewed Jun 18, 2018

View reviewed changes

sharkykh reviewed Jun 23, 2018

View reviewed changes

OmgImAlexis added this to the backlog milestone Jun 24, 2018

OmgImAlexis modified the milestones: backlog, 0.2.7 Jun 24, 2018

p0psicles mentioned this pull request Jun 25, 2018

More renaming variables (For Anime) #4451

Closed

p0psicles added 4 commits June 25, 2018 12:01

Move config items to DataGenerator class.

f575f92

* Extend config items.

Sync light theme

9ec87d7

Move convert method from main.mako to inc_defs.mako.

45a126f

Update name-pattern. Need to overwrite from develop.

eba9e60

p0psicles added 3 commits July 29, 2018 21:05

Wait for all the properties (data send from parent) before starting t…

8256a96

…o make api calls. * Update the snapshots.

Remove unused method.

c6b8e44

Fix lint warning.

3717fde

OmgImAlexis previously approved these changes Jul 30, 2018

View reviewed changes

p0psicles added 2 commits July 31, 2018 13:12

Add component-group-desc-legacy to keep the min width of 200px. For p…

3271788

…ages that have not been made responsive yet.

p0psicles dismissed OmgImAlexis’s stale review via 4a3b684 July 31, 2018 11:15

OmgImAlexis previously approved these changes Jul 31, 2018

View reviewed changes

OmgImAlexis removed Needs review Needs test (Vue) Needs tests added for this change (Vue) Needs testing Requires testing to make sure it's working as intended labels Jul 31, 2018

Fixed type (while / will).

ae98773

* Hide the name-pattern legend, when changing from custom pattern to preset.

p0psicles dismissed OmgImAlexis’s stale review via ae98773 July 31, 2018 15:24

Fix pytest to 3.6.4.

469ea8f

OmgImAlexis approved these changes Aug 1, 2018

View reviewed changes

OmgImAlexis added Concluded and removed In progress labels Aug 1, 2018

p0psicles merged commit 7daab93 into develop Aug 1, 2018

p0psicles deleted the feature/vueify-postprocessing branch August 1, 2018 01:10

sharkykh mentioned this pull request Aug 5, 2018

UI bugfixes #4851

Merged

sharkykh mentioned this pull request Sep 4, 2018

Convert Post Processing Config to VueRouter #4946

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vueify config-postprocessing #4259

Vueify config-postprocessing #4259

p0psicles commented May 27, 2018 •

edited by sharkykh

Loading

OmgImAlexis May 28, 2018

OmgImAlexis May 28, 2018

p0psicles May 30, 2018

OmgImAlexis Jun 16, 2018

OmgImAlexis May 28, 2018 •

edited

Loading

OmgImAlexis May 28, 2018

p0psicles May 30, 2018

OmgImAlexis Jun 16, 2018

OmgImAlexis May 30, 2018

OmgImAlexis Jun 18, 2018

sharkykh Jun 23, 2018

OmgImAlexis commented Jun 24, 2018

p0psicles commented Jun 24, 2018 •

edited

Loading

p0psicles commented Jul 29, 2018

sharkykh commented Jul 29, 2018

p0psicles commented Jul 29, 2018

sharkykh commented Jul 29, 2018

p0psicles commented Jul 29, 2018

p0psicles commented Jul 29, 2018

p0psicles commented Jul 29, 2018

OmgImAlexis Jul 31, 2018

p0psicles commented Jul 31, 2018

p0psicles commented Jul 31, 2018

		@@ -0,0 +1,378 @@
		<script type="text/x-template" id="name-pattern-tempate">
		<div id="name_pattern_wrapper">

		<p>Settings that dictate how Medusa should process completed downloads.</p>
		<p>The scheduled postprocessor while periodically scan a folder for media to process.</p>

Vueify config-postprocessing #4259

Vueify config-postprocessing #4259

Conversation

p0psicles commented May 27, 2018 • edited by sharkykh Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OmgImAlexis May 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OmgImAlexis commented Jun 24, 2018

p0psicles commented Jun 24, 2018 • edited Loading

p0psicles commented Jul 29, 2018

sharkykh commented Jul 29, 2018

p0psicles commented Jul 29, 2018

sharkykh commented Jul 29, 2018

p0psicles commented Jul 29, 2018

p0psicles commented Jul 29, 2018

p0psicles commented Jul 29, 2018

Choose a reason for hiding this comment

p0psicles commented Jul 31, 2018

p0psicles commented Jul 31, 2018

p0psicles commented May 27, 2018 •

edited by sharkykh

Loading

OmgImAlexis May 28, 2018 •

edited

Loading

p0psicles commented Jun 24, 2018 •

edited

Loading