Convert submenu to Vue #4739
Merged
Convert submenu to Vue #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Remove unused /home/testRename submenu code
|
This is as far as I can go with this at the moment. The last Python conversion requires that all the routes be listed on the VueRouter (#4663). |
OmgImAlexis
reviewed
Jul 25, 2018
| @@ -61,7 +61,7 @@ | |||
|
|
|||
| <app-header></app-header> | |||
| % if submenu: | |||
| <%include file="/partials/submenu.mako"/> | |||
| <submenu></submenu> | |||
There was a problem hiding this comment.
All components should use a 2 section name like sub-menu, app-header, etc. to avoid mixing with custom-html elements. I think the @vue/recommended eslint rule adds this. We currently use the basic version.
OmgImAlexis
reviewed
Jul 25, 2018
| <template v-for="menuItem in submenu"> | ||
| <app-link :key="menuItem.title" :href="menuItem.path" class="btn-medusa top-5 bottom-5" | ||
| v-if="!menuItem.confirm"> | ||
| <span :class="`pull-left ${menuItem.icon || ''}`"></span> {{ menuItem.title }} |
There was a problem hiding this comment.
Please use :class="['pull-left', menuItem.icon]" instead.
p0psicles
previously approved these changes
Jul 25, 2018
OmgImAlexis
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is set for v0.2.7 because it fixes the bug with the confirmation dialogs for removing shows, clearing history, etc.
To do:
controller !== 'schedule' && action !== 'previewRename'.For
previewRename- either remove the submenu argument from the handler,or keep it - if we want it. Make sure removing that submenu has no effect.
location.pathnamehasdisplayShow?not-foundredirection for now