Convert titles and headers to VueRouter #4663

OmgImAlexis · 2018-07-13T00:37:42Z

Sorry for the single commit.

sharkykh · 2018-07-13T01:36:51Z

themes-default/slim/views/home.mako

+        computed: {
+            isRoute() {
+                const { matched } = this.$route;
+                return matched.filter(route => route.components.default !== undefined).length >= 1;


What's this property for?

It's for the future. It returns true if we have a matched component vs a matched route.

For the home "partials"?

No for determining if you're in a Vue component or a mako template.

sharkykh · 2018-07-13T02:12:10Z

sharkykh · 2018-08-06T16:00:34Z

I recreated the branch on top of current develop, because we had so many changes (to develop),
so I went over the files and manually made the same changes this PR had before.
Hopefully I didn't make a mistake. A quick glance at the pages, especially help & info, home, displayShow and editShow, looks like everything is still good.

sharkykh · 2018-08-06T16:12:14Z

themes-default/slim/views/home.mako

+    computed: {
+        isRoute() {
+            const { matched } = this.$route;
+            return matched.filter(route => route.components.default !== undefined).length >= 1;


Unfortunately I still don't really understand why it's needed.
If you go to /home/displayShow it shouldn't load the home component.

It can be removed now. I was going to load all the pages differently than how I am now.

OmgImAlexis · 2018-08-22T09:09:56Z

themes-default/slim/views/errorlogs.mako

@@ -4,12 +4,24 @@
    from medusa import classes
 %>
 <%block name="scripts">
+
+<%
+    if logLevel == logger.WARNING:


Is this not available via URL params?

Hmm, yes, I can use that instead.

Just gets us closer to SFC.

sharkykh · 2018-08-22T11:47:52Z

The only thing that really bugs me about this PR is the extra router-view component it adds for nested routes.
Maybe we should just drop the children as it seems to be intended for actual nested views...

OmgImAlexis · 2018-08-23T04:27:18Z

@sharkykh if you can find a way to do nested routes without it then by all means suggest away. The way I've used is what has been recommended over and over by the devs.

* /home/snatchSelection * /home/testRename * /home/postprocess * /home/status

* /addShows/trendingShows * /addShows/popularShows * /addShows/popularAnime

* /news * /changes * /IRC

sharkykh · 2018-08-23T07:15:21Z

@OmgImAlexis Last commit 'fixes' it.
I'm sure we can also find a way to not write the path prefix for each route group (/home/, /config/), if you don't like it.

They don't have paths so nothing to add to the router.

OmgImAlexis · 2018-08-23T08:10:20Z

themes-default/slim/test/specs/router.spec.js

+import router from '../../src/router';
+
+test('router compiles', t => {
+    t.truthy(router);


I think notThrows would work better here.

notThrows requires a function, but the import happens at the top of the file.

OmgImAlexis

LGTM

OmgImAlexis added Enhancement In progress labels Jul 13, 2018

OmgImAlexis added this to the 0.2.7 milestone Jul 13, 2018

OmgImAlexis requested a review from sharkykh July 13, 2018 00:37

sharkykh reviewed Jul 13, 2018

View reviewed changes

This comment has been minimized.

Sign in to view

OmgImAlexis modified the milestones: 0.2.7, 0.2.8 Jul 21, 2018

This comment has been minimized.

Sign in to view

sharkykh mentioned this pull request Jul 24, 2018

Convert submenu to Vue #4739

Merged

4 tasks

This comment has been minimized.

Sign in to view

sharkykh force-pushed the feature/vueify-title-and-header branch from 770956b to 4e2a350 Compare August 6, 2018 15:54

sharkykh reviewed Aug 6, 2018

View reviewed changes

sharkykh force-pushed the feature/vueify-title-and-header branch from d2049a0 to 6079d37 Compare August 21, 2018 12:14

p0psicles mentioned this pull request Aug 21, 2018

Remove MEDUSA.config and startVue #4765

Open

38 tasks

sharkykh changed the title ~~convert most title and headers to vue router~~ Convert titles and headers to VueRouter Aug 21, 2018

sharkykh mentioned this pull request Aug 21, 2018

Remove startVue and misc #4937

Merged

24 tasks

sharkykh force-pushed the feature/vueify-title-and-header branch from 56c6784 to c636316 Compare August 22, 2018 06:30

OmgImAlexis commented Aug 22, 2018

View reviewed changes

OmgImAlexis and others added 13 commits August 23, 2018 10:09

Add routes

8d18cde

Update templates for the added routes

713b1ec

Sync themes

211db15

Webpack

4f0973c

More /home routes

7a98684

* /home/snatchSelection * /home/testRename * /home/postprocess * /home/status

More /addShows routes

790758e

* /addShows/trendingShows * /addShows/popularShows * /addShows/popularAnime

More / routes

eb50bf6

* /news * /changes * /IRC

Move /errorlogs routes

9c6ad13

Restart & Shutdown

d9b7ee0

Format router.js

5624f59

Add missing router, change errorlogs header

b6983e6

Update errorlogs.mako

90718f7

Simplify route nesting

f827b36

sharkykh force-pushed the feature/vueify-title-and-header branch from 13f5c18 to f827b36 Compare August 23, 2018 07:10

Add (extremely) simple router test

f56a52b

sharkykh added Needs review Frontend Concluded and removed In progress labels Aug 23, 2018

sharkykh added 2 commits August 23, 2018 10:39

Put router after store in schedule.mako

2961cfe

Add router to 404.mako 500.mako

e76e26d

They don't have paths so nothing to add to the router.

OmgImAlexis commented Aug 23, 2018

View reviewed changes

sharkykh approved these changes Aug 23, 2018

View reviewed changes

OmgImAlexis merged commit 7cb7584 into develop Aug 23, 2018

OmgImAlexis deleted the feature/vueify-title-and-header branch August 23, 2018 08:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert titles and headers to VueRouter #4663

Convert titles and headers to VueRouter #4663

OmgImAlexis commented Jul 13, 2018

sharkykh Jul 13, 2018 •

edited

Loading

OmgImAlexis Jul 13, 2018

sharkykh Jul 13, 2018

OmgImAlexis Jul 13, 2018

sharkykh commented Jul 13, 2018 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sharkykh commented Aug 6, 2018 •

edited

Loading

sharkykh Aug 6, 2018

OmgImAlexis Aug 7, 2018

OmgImAlexis Aug 22, 2018

sharkykh Aug 22, 2018

OmgImAlexis Aug 23, 2018

sharkykh commented Aug 22, 2018 •

edited

Loading

OmgImAlexis commented Aug 23, 2018

sharkykh commented Aug 23, 2018

OmgImAlexis Aug 23, 2018

sharkykh Aug 23, 2018

OmgImAlexis left a comment

Convert titles and headers to VueRouter #4663

Convert titles and headers to VueRouter #4663

Conversation

OmgImAlexis commented Jul 13, 2018

sharkykh Jul 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sharkykh commented Jul 13, 2018 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sharkykh commented Aug 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sharkykh commented Aug 22, 2018 • edited Loading

OmgImAlexis commented Aug 23, 2018

sharkykh commented Aug 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OmgImAlexis left a comment

Choose a reason for hiding this comment

sharkykh Jul 13, 2018 •

edited

Loading

sharkykh commented Jul 13, 2018 •

edited

Loading

sharkykh commented Aug 6, 2018 •

edited

Loading

sharkykh commented Aug 22, 2018 •

edited

Loading