Fix adding 2+ shows (that need searching) using Add Existing Show #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backported from #4267 and tweaked
OmgImAlexis
reviewed
Jun 2, 2018
|
|
||
| # go to add the next show | ||
| return self.newShow(next_show_dir, rest_of_show_dirs) | ||
| return json_redirect( | ||
| '/addShows/newShow/', |
There was a problem hiding this comment.
Won't this also need the other query params like if the user wants auto settings or settings picked manually for each, etc?
There was a problem hiding this comment.
No, because the form on addShow/existingShows doesn't POST to this endpoint (addShow/addNewShow), but rather to addShow/addExistingShows (notice add at the start).
This ^ endpoint handles the promptForSettings stuff and then redirects us to the addShow/newShow page with the correct parameters. That's why the first show that needs searching always works.
It's only addShow/newShow that POSTs to addShow/addNewShow which needs this patch, at least for right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug where after adding the first show you were redirected to the home page instead of the next show.
Make
addShows/addNewShowreturn a redirection url instead of redirectingBackported from #4267 and tweaked
Tested.
@OmgImAlexis Apologies.