Vueify/new show #4267
Vueify/new show #4267
Conversation
sharkykh
force-pushed
the
vueify/new-show
branch
2 times, most recently
from
11f81a0 to
457d47e
Compare
| const { data } = response; | ||
| const { result, message, redirect, params } = data; | ||
|
|
||
| if (message.length !== 0) { |
There was a problem hiding this comment.
Since this isn't an array use if (message) {}. Same goes for the redirect.length below.
Backported from #4267 and tweaked
) * Make addShows/addNewShow return a redirection url instead of redirecting Backported from #4267 and tweaked * Fix JS
sharkykh
force-pushed
the
vueify/new-show
branch
from
5766057 to
4f7bbf5
Compare
sharkykh
force-pushed
the
vueify/new-show
branch
from
4f7bbf5 to
3b44d47
Compare
|
@sharkykh is this going to be ready for |
|
@OmgImAlexis It depends on how far I'm willing to go with this. |
* New search UI * Move data endpoints to /api/v2/internal Use axios with request cancellation for the show search. * Unify responses: No redirects, return either a rendered template, or a JSON response
* Unify responses: No redirects, return either a rendered template, or a JSON response * Fixed a bug where if you supplied only the show's directory it would get added to the list of shows to add twice.
* Unify responses: No redirects, return either a rendered template, or a JSON response
sharkykh
force-pushed
the
vueify/new-show
branch
from
3b44d47 to
4410a11
Compare
| search_terms = [query] | ||
|
|
||
| # If search term ends with what looks like a year, enclose it in () | ||
| matches = re.match(r'^(.+ |)([12][0-9]{3})$', query) |
There was a problem hiding this comment.
Can probably add this as another PR but we also need to do vs and vs. as I found with Red vs. Blue.
| <script src="js/vue-submit-form.js"></script> | ||
| ## <script src="js/lib/[email protected]"></script> | ||
| ## <script src="js/lib/vue-frisbee.min.js"></script> | ||
| ## <script src="js/vue-submit-form.js"></script> |
There was a problem hiding this comment.
These should be removed before merging.
There was a problem hiding this comment.
Should I keep the files though?
There was a problem hiding this comment.
They're used in other files right? I was mainly talking about the python comment.
There was a problem hiding this comment.
Ah well, no, they're unused.
frisbee (vue-frisbee) is only used in vue-submit-form, and vue-submit-form was only used in newShow.
There was a problem hiding this comment.
If they're unused remove the libs as we can always add them back.
| </form> | ||
| <br> | ||
| <br /> |
There was a problem hiding this comment.
The other style is preferred in HTML5.
Depends on ✔️
#4059+ ✔️#4283There are some commits that don't belong in this branch. I will clean it when the time comes :)Showing off the new UI 😉 (gif is a bit outdated though)
GIF