Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mermaid dotted arrow #9031

Merged
merged 1 commit into from
Sep 16, 2023
Merged

fix mermaid dotted arrow #9031

merged 1 commit into from
Sep 16, 2023

Conversation

agusdmb
Copy link
Contributor

@agusdmb agusdmb commented Sep 12, 2023 •
edited
Loading

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

There is an issue with a mermaid arrow.

Check:
Closes #9030

The issue was introduced in:
#8824

it should be:
mod_c ..> mod_a
as documented here:
https://mermaid.js.org/syntax/classDiagram.html#defining-relationship

github renders mermaid files, and if we try to open this one we get an error, see:
https://github.com/pylint-dev/pylint/blob/ffe1e714a3cfe83b5a627ade6d723489f2e10621/tests/pyreverse/functional/package_diagrams/type_check_imports/packages.mmd

with this fix now the file renders without issue:
https://github.com/pylint-dev/pylint/blob/83ade2f16272153ae077b03c5c8ffd341b03cf25/tests/pyreverse/functional/package_diagrams/type_check_imports/packages.mmd

Originally posted by @agusdmb in #8824 (comment)

@agusdmb agusdmb requested a review from DudeNr33 as a code owner September 12, 2023 20:32
@agusdmb agusdmb mentioned this pull request Sep 12, 2023
Merged
3 tasks
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #9031 (83ade2f) into main (7d04b75) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9031   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files         173      173           
  Lines       18648    18648           
=======================================
  Hits        17856    17856           
  Misses        792      792
Files Changed Coverage Ξ”
pylint/pyreverse/mermaidjs_printer.py 98.18% <ΓΈ> (ΓΈ)

@nickdrozd
Copy link
Contributor

Nice catch. It would be cool if there was a way to test for this.

@nickdrozd nickdrozd added pyreverse Related to pyreverse component Skip news πŸ”‡ This change does not require a changelog entry Bug πŸͺ² labels Sep 12, 2023
@agusdmb
Copy link
Contributor Author

agusdmb commented Sep 12, 2023

Nice catch. It would be cool if there was a way to test for this.

Do you mean like running a mermaid parser to the output file?

@nickdrozd
Copy link
Contributor

Do you mean like running a mermaid parser to the output file?

Yeah, but I don't know if there is an easy way to do that. And there are other output formats too, none of which I personally use. I thought I had manually tested the output, but obviously not well enough!

@github-actions
Copy link
Contributor

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on home-assistant:
The following messages are now emitted:

  1. locally-disabled:
    Locally disabling protected-access (W0212)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/runner.py#L175
  2. suppressed-message:
    Suppressed 'protected-access' (from line 166)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/runner.py#L166
  3. suppressed-message:
    Suppressed 'protected-access' (from line 175)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/runner.py#L175
  4. locally-disabled:
    Locally disabling broad-exception-caught (W0718)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L704
  5. line-too-long:
    Line too long (104/100)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L467
  6. too-many-lines:
    Too many lines in module (1311/1000)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L1
  7. import-error:
    Unable to import 'voluptuous'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L27
  8. while-used:
    Used while loop
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L126
  9. too-many-instance-attributes:
    Too many instance attributes (11/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L221
  10. too-many-instance-attributes:
    Too many instance attributes (17/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L239
  11. too-many-return-statements:
    Too many return statements (7/6)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L354
  12. no-self-use:
    Method could be a function
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L418
  13. consider-ternary-expression:
    Consider rewriting as a ternary expression
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L467
  14. no-self-use:
    Method could be a function
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L504
  15. consider-using-assignment-expr:
    Use 'if (name := self.name) is UNDEFINED:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L771
  16. magic-value-comparison:
    Consider using a named constant or an enum instead of '0.4'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L853
  17. too-many-try-statements:
    try clause contains 2 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L955
  18. while-used:
    Used while loop
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L1005
  19. magic-value-comparison:
    Consider using a named constant or an enum instead of 'custom_components'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L1086
  20. magic-value-comparison:
    Consider using a named constant or an enum instead of 'remove'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L1122
  21. magic-value-comparison:
    Consider using a named constant or an enum instead of 'update'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L1127
  22. magic-value-comparison:
    Consider using a named constant or an enum instead of 'device_id'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L1130
  23. magic-value-comparison:
    Consider using a named constant or an enum instead of 'update'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L1172
  24. magic-value-comparison:
    Consider using a named constant or an enum instead of 'name'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L1175
  25. magic-value-comparison:
    Consider using a named constant or an enum instead of 'name_by_user'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L1175
  26. magic-value-comparison:
    Consider using a named constant or an enum instead of 'custom_components'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L1233
  27. too-many-public-methods:
    Too many public methods (46/20)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L239
  28. suppressed-message:
    Suppressed 'broad-exception-caught' (from line 704)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/entity.py#L704
  29. locally-disabled:
    Locally disabling import-outside-toplevel (C0415)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/service.py#L77
  30. suppressed-message:
    Suppressed 'import-outside-toplevel' (from line 77)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/service.py#L77
  31. locally-disabled:
    Locally disabling protected-access (W0212)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L915
  32. locally-disabled:
    Locally disabling protected-access (W0212)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L937
  33. locally-disabled:
    Locally disabling protected-access (W0212)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1051
  34. locally-disabled:
    Locally disabling protected-access (W0212)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1111
  35. too-many-lines:
    Too many lines in module (1851/1000)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1
  36. too-complex:
    '_find_referenced_areas' is too complex. The McCabe rating is 11
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1348
  37. too-complex:
    '_find_referenced_devices' is too complex. The McCabe rating is 15
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1388
  38. too-complex:
    '_find_referenced_entities' is too complex. The McCabe rating is 15
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1438
  39. too-complex:
    'async_run' is too complex. The McCabe rating is 20
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1486
  40. unused-argument:
    Unused argument 'point_in_time'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1125
  41. unused-argument:
    Unused argument 'event'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1143
  42. too-many-instance-attributes:
    Too many instance attributes (29/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1200
  43. too-many-arguments:
    Too many arguments (15/5)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1203
  44. too-many-locals:
    Too many local variables (16/15)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1203
  45. confusing-consecutive-elif:
    Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1368
  46. confusing-consecutive-elif:
    Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1373
  47. confusing-consecutive-elif:
    Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1416
  48. confusing-consecutive-elif:
    Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1423
  49. too-many-branches:
    Too many branches (14/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1388
  50. confusing-consecutive-elif:
    Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1467
  51. confusing-consecutive-elif:
    Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1474
  52. too-many-branches:
    Too many branches (14/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1438
  53. magic-value-comparison:
    Consider using a named constant or an enum instead of 'SILENT'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1507
  54. magic-value-comparison:
    Consider using a named constant or an enum instead of 'SILENT'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1512
  55. consider-ternary-expression:
    Consider rewriting as a ternary expression
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1556
  56. too-many-branches:
    Too many branches (20/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1486
  57. too-many-statements:
    Too many statements (53/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1486
  58. unused-argument:
    Unused argument 'spare'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1585
  59. consider-ternary-expression:
    Consider rewriting as a ternary expression
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1606
  60. redefined-loop-name:
    Redefining 'parallel_script' from loop (line 1747)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1749
  61. suppressed-message:
    Suppressed 'protected-access' (from line 915)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L915
  62. suppressed-message:
    Suppressed 'protected-access' (from line 937)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L937
  63. suppressed-message:
    Suppressed 'protected-access' (from line 1051)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1051
  64. suppressed-message:
    Suppressed 'protected-access' (from line 1111)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/script.py#L1111
  65. locally-disabled:
    Locally disabling super-init-not-called (W0231)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/template.py#L941
  66. suppressed-message:
    Suppressed 'super-init-not-called' (from line 941)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/helpers/template.py#L941
  67. locally-disabled:
    Locally disabling import-outside-toplevel (C0415)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L48
  68. locally-disabled:
    Locally disabling protected-access (W0212)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L203
  69. locally-disabled:
    Locally disabling broad-exception-caught (W0718)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L218
  70. too-complex:
    'run' is too complex. The McCabe rating is 18
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L59
  71. too-complex:
    'check' is too complex. The McCabe rating is 14
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L157
  72. consider-using-namedtuple-or-dataclass:
    Consider using namedtuple or dataclass for dictionary values
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L33
  73. import-error:
    Unable to import 'colorlog.escape_codes'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L48
  74. too-many-try-statements:
    try clause contains 4 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L50
  75. too-many-locals:
    Too many local variables (19/15)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L59
  76. magic-value-comparison:
    Consider using a named constant or an enum instead of 'all'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L120
  77. too-many-branches:
    Too many branches (18/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L59
  78. too-many-statements:
    Too many statements (52/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L59
  79. unused-argument:
    Unused argument 'script_args'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L59
  80. magic-value-comparison:
    Consider using a named constant or an enum instead of 'secrets'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L186
  81. too-many-try-statements:
    try clause contains 8 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L206
  82. magic-value-comparison:
    Consider using a named constant or an enum instead of 'platform'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L264
  83. suppressed-message:
    Suppressed 'import-outside-toplevel' (from line 48)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L48
  84. suppressed-message:
    Suppressed 'protected-access' (from line 203)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L203
  85. suppressed-message:
    Suppressed 'broad-exception-caught' (from line 218)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L218
  86. suppressed-message:
    Suppressed 'possibly-unused-variable' (from line 169)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L169
  87. suppressed-message:
    Suppressed 'possibly-unused-variable' (from line 175)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/scripts/check_config.py#L175
  88. locally-disabled:
    Locally disabling too-many-nested-blocks (R1702)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L492
  89. empty-comment:
    Line with empty comment
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L403
  90. too-complex:
    '_compile_statistics' is too complex. The McCabe rating is 33
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L412
  91. too-complex:
    'validate_statistics' is too complex. The McCabe rating is 12
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L700
  92. use-set-for-membership:
    Consider using set for membership test
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L302
  93. consider-ternary-expression:
    Consider rewriting as a ternary expression
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L373
  94. too-many-locals:
    Too many local variables (36/15)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L412
  95. magic-value-comparison:
    Consider using a named constant or an enum instead of 'sum'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L425
  96. magic-value-comparison:
    Consider using a named constant or an enum instead of 'sum'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L440
  97. magic-value-comparison:
    Consider using a named constant or an enum instead of 'sum'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L486
  98. magic-value-comparison:
    Consider using a named constant or an enum instead of 'mean'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L525
  99. magic-value-comparison:
    Consider using a named constant or an enum instead of 'sum'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L526
  100. magic-value-comparison:
    Consider using a named constant or an enum instead of 'max'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L535
  101. magic-value-comparison:
    Consider using a named constant or an enum instead of 'min'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L542
  102. magic-value-comparison:
    Consider using a named constant or an enum instead of 'mean'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L550
  103. magic-value-comparison:
    Consider using a named constant or an enum instead of 'sum'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L553
  104. too-many-try-statements:
    try clause contains 3 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L609
  105. too-many-branches:
    Too many branches (34/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L412
  106. too-many-statements:
    Too many statements (95/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L412
  107. magic-value-comparison:
    Consider using a named constant or an enum instead of 'sum'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L681
  108. magic-value-comparison:
    Consider using a named constant or an enum instead of 'mean'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L688
  109. magic-value-comparison:
    Consider using a named constant or an enum instead of 'sum'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L689
  110. too-many-locals:
    Too many local variables (17/15)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L700
  111. confusing-consecutive-elif:
    Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L769
  112. consider-using-assignment-expr:
    Use 'if not (converter := statistics.STATISTIC_UNIT_TO_UNIT_CONVERTER.get(metadata_unit)):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L740
  113. confusing-consecutive-elif:
    Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L754
  114. unused-argument:
    Unused argument 'hass'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L796
  115. suppressed-message:
    Suppressed 'too-many-nested-blocks' (from line 492)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/recorder.py#L492
  116. unknown-option-value:
    Unknown option value for 'disable-next', expected a valid pylint message and got 'hass-deprecated-import'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/sensor/__init__.py#L16
  117. use-implicit-booleaness-not-comparison-to-zero:
    "self._cover.current_position == 0" can be simplified to "not self._cover.current_position", if it is strictly an int, as 0 is falsey
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/netatmo/cover.py#L68
  118. use-implicit-booleaness-not-comparison-to-zero:
    "self._cover.current_position == 0" can be simplified to "not self._cover.current_position", if it is strictly an int, as 0 is falsey
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/netatmo/cover.py#L105
  119. too-complex:
    '_resolve_entity' is too complex. The McCabe rating is 11
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/search/__init__.py#L242
  120. unused-argument:
    Unused argument 'config'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/search/__init__.py#L30
  121. while-used:
    Used while loop
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/search/__init__.py#L120
  122. magic-value-comparison:
    Consider using a named constant or an enum instead of 'entity'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/search/__init__.py#L131
  123. consider-using-assignment-expr:
    Use 'if (domain := split_entity_id(item_id)[0]) in self.EXIST_AS_ENTITY:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/search/__init__.py#L134
  124. consider-using-assignment-expr:
    Use 'if (device_entry := self._device_reg.async_get(device_id)) is not None:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/search/__init__.py#L222
  125. consider-using-assignment-expr:
    Use 'if (entity_entry := self._entity_reg.async_get(entity_id)) is not None:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/search/__init__.py#L263
  126. magic-value-comparison:
    Consider using a named constant or an enum instead of 'config_entry'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/search/__init__.py#L271
  127. consider-using-assignment-expr:
    Use 'if (domain := split_entity_id(entity_id)[0]) in self.EXIST_AS_ENTITY:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/search/__init__.py#L276
  128. too-few-public-methods:
    Too few public methods (1/2)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/search/__init__.py#L75
  129. magic-value-comparison:
    Consider using a named constant or an enum instead of 'STANDBY'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/soundtouch/media_player.py#L125
  130. magic-value-comparison:
    Consider using a named constant or an enum instead of 'INVALID_SOURCE'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/soundtouch/media_player.py#L128
  131. unused-argument:
    Unused argument 'event'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/soundtouch/media_player.py#L226
  132. missing-type-doc:
    "slaves" missing in parameter type documentation
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/soundtouch/media_player.py#L283
  133. missing-type-doc:
    "slaves" missing in parameter type documentation
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/soundtouch/media_player.py#L295
  134. missing-type-doc:
    "slaves" missing in parameter type documentation
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/soundtouch/media_player.py#L319
  135. magic-value-comparison:
    Consider using a named constant or an enum instead of 'master'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/soundtouch/media_player.py#L340
  136. consider-using-assignment-expr:
    Use 'if not (zone_status := self._device.zone_status()):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/soundtouch/media_player.py#L360
  137. consider-using-assignment-expr:
    Use 'if (master_instance := self._get_instance_by_id(zone_status.master_id)) is not None:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/soundtouch/media_player.py#L378
  138. too-many-public-methods:
    Too many public methods (33/20)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/soundtouch/media_player.py#L61
  139. line-too-long:
    Line too long (104/100)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/dynalite/cover.py#L90
  140. consider-using-assignment-expr:
    Use 'if (target_level := state.attributes.get(ATTR_CURRENT_POSITION)) is not None:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/dynalite/cover.py#L85
  141. import-error:
    Unable to import 'pyinsteon.device_types.ipdb'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/ipdb.py#L5
  142. import-error:
    Unable to import 'pyinsteon.device_types.device_base'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/light.py#L5
  143. unused-argument:
    Unused argument 'config_entry'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/light.py#L23
  144. too-complex:
    'get_properties' is too complex. The McCabe rating is 11
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L101
  145. import-error:
    Unable to import 'pyinsteon.config'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L6
  146. import-error:
    Unable to import 'pyinsteon.constants'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L12
  147. import-error:
    Unable to import 'pyinsteon.device_types.device_base'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L19
  148. import-error:
    Unable to import 'voluptuous'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L20
  149. import-error:
    Unable to import 'voluptuous_serialize'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L21
  150. too-many-return-statements:
    Too many return statements (10/6)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L76
  151. consider-using-assignment-expr:
    Use 'if (prop_schema := get_schema(prop, name, device.groups)) is None:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L112
  152. consider-using-assignment-expr:
    Use 'if (prop_schema := get_schema(prop, name, device.groups)) is not None:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L122
  153. consider-using-assignment-expr:
    Use 'if (prop_schema := get_schema(prop, name, device.groups)) is not None:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L129
  154. unused-argument:
    Unused argument 'hass'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L169
  155. unused-argument:
    Unused argument 'hass'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L194
  156. unused-argument:
    Unused argument 'hass'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/insteon/api/properties.py#L277
  157. magic-value-comparison:
    Consider using a named constant or an enum instead of 'tv'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/roku/media_player.py#L128
  158. too-many-public-methods:
    Too many public methods (27/20)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/roku/media_player.py#L107
  159. unused-argument:
    Unused argument 'config_entry'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/speedtestdotnet/sensor.py#L68
  160. magic-value-comparison:
    Consider using a named constant or an enum instead of 'download'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/speedtestdotnet/sensor.py#L125
  161. magic-value-comparison:
    Consider using a named constant or an enum instead of 'upload'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/speedtestdotnet/sensor.py#L129
  162. consider-using-assignment-expr:
    Use 'if not (payload := str(self._value_template(msg.payload))):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/lawn_mower.py#L174
  163. magic-value-comparison:
    Consider using a named constant or an enum instead of 'none'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/lawn_mower.py#L181
  164. too-many-instance-attributes:
    Too many instance attributes (8/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/switch.py#L88
  165. too-complex:
    '_prepare_subscribe_topics' is too complex. The McCabe rating is 26
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/humidifier.py#L310
  166. too-many-instance-attributes:
    Too many instance attributes (19/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/humidifier.py#L207
  167. consider-using-assignment-expr:
    Use 'if not (payload := self._value_templatesCONF_STATE):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/humidifier.py#L319
  168. magic-value-comparison:
    Consider using a named constant or an enum instead of '100'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/humidifier.py#L378
  169. too-many-statements:
    Too many statements (64/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/humidifier.py#L310
  170. too-complex:
    '_prepare_subscribe_topics' is too complex. The McCabe rating is 14
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/siren.py#L221
  171. too-many-instance-attributes:
    Too many instance attributes (11/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/siren.py#L138
  172. too-many-try-statements:
    try clause contains 2 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/siren.py#L240
  173. too-many-try-statements:
    try clause contains 2 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/siren.py#L271
  174. consider-ternary-expression:
    Consider rewriting as a ternary expression
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/siren.py#L331
  175. too-complex:
    '_prepare_subscribe_topics' is too complex. The McCabe rating is 25
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/fan.py#L353
  176. too-many-instance-attributes:
    Too many instance attributes (22/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/fan.py#L215
  177. consider-using-assignment-expr:
    Use 'if not (payload := self._value_templatesCONF_STATE):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/fan.py#L373
  178. magic-value-comparison:
    Consider using a named constant or an enum instead of '100'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/fan.py#L415
  179. consider-using-assignment-expr:
    Use 'if not (payload := self._value_templatesATTR_OSCILLATING):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/fan.py#L462
  180. consider-using-assignment-expr:
    Use 'if not (direction := self._value_templatesATTR_DIRECTION):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/fan.py#L479
  181. too-many-statements:
    Too many statements (58/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/fan.py#L353
  182. consider-ternary-expression:
    Consider rewriting as a ternary expression
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/fan.py#L591
  183. too-many-instance-attributes:
    Too many instance attributes (11/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/text.py#L124
  184. too-many-instance-attributes:
    Too many instance attributes (13/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/lock.py#L126
  185. consider-using-assignment-expr:
    Use 'if (payload := self._value_template(msg.payload)) in self._valid_states:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/lock.py#L196
  186. too-complex:
    '_prepare_subscribe_topics' is too complex. The McCabe rating is 23
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/cover.py#L357
  187. too-many-ancestors:
    Too many ancestors (8/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/cover.py#L235
  188. too-many-instance-attributes:
    Too many instance attributes (14/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/cover.py#L235
  189. too-many-boolean-expressions:
    Too many boolean expressions in if statement (7/5)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/cover.py#L290
  190. consider-using-assignment-expr:
    Use 'if not (payload := self._tilt_status_template(msg.payload)):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/cover.py#L367
  191. consider-using-assignment-expr:
    Use 'if not (payload := self._value_template(msg.payload)):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/cover.py#L379
  192. magic-value-comparison:
    Consider using a named constant or an enum instead of 'position'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/cover.py#L429
  193. magic-value-comparison:
    Consider using a named constant or an enum instead of 'tilt_position'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/cover.py#L435
  194. too-many-statements:
    Too many statements (54/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/cover.py#L357
  195. too-complex:
    '_prepare_subscribe_topics' is too complex. The McCabe rating is 38
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L402
  196. too-complex:
    'async_turn_on' is too complex. The McCabe rating is 30
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L672
  197. too-many-instance-attributes:
    Too many instance attributes (31/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L242
  198. too-many-statements:
    Too many statements (55/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L282
  199. redefined-variable-type:
    Redefinition of self._attr_color_mode type from homeassistant.components.light.ColorMode.COLOR_TEMP to homeassistant.components.light.ColorMode.HS
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L362
  200. consider-using-assignment-expr:
    Use 'if (device_value := float(payload)) == 0:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L455
  201. use-implicit-booleaness-not-comparison-to-zero:
    "device_value == 0" can be simplified to "not device_value", if it is strictly an int, as 0 is falsey
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L455
  202. consider-using-assignment-expr:
    Use 'if (brightness := max(rgb)) == 0:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L487
  203. use-implicit-booleaness-not-comparison-to-zero:
    "brightness == 0" can be simplified to "not brightness", if it is strictly an int, as 0 is falsey
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L487
  204. too-many-try-statements:
    try clause contains 5 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L609
  205. too-many-statements:
    Too many statements (96/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L402
  206. too-many-locals:
    Too many local variables (37/15)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L672
  207. magic-value-comparison:
    Consider using a named constant or an enum instead of 'first'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L736
  208. magic-value-comparison:
    Consider using a named constant or an enum instead of 'brightness'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L744
  209. magic-value-comparison:
    Consider using a named constant or an enum instead of 'last'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L876
  210. too-many-branches:
    Too many branches (18/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L672
  211. too-many-statements:
    Too many statements (107/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_basic.py#L672
  212. too-complex:
    '_prepare_subscribe_topics' is too complex. The McCabe rating is 19
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L213
  213. too-complex:
    'async_turn_on' is too complex. The McCabe rating is 14
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L319
  214. too-many-instance-attributes:
    Too many instance attributes (18/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L128
  215. consider-using-augmented-assign:
    Use '|=' to do an augmented assign directly
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L203
  216. too-many-try-statements:
    try clause contains 2 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L231
  217. too-many-try-statements:
    try clause contains 2 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L248
  218. magic-value-comparison:
    Consider using a named constant or an enum instead of 'None'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L253
  219. too-many-try-statements:
    try clause contains 6 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L263
  220. magic-value-comparison:
    Consider using a named constant or an enum instead of 'None'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L267
  221. magic-value-comparison:
    Consider using a named constant or an enum instead of 'None'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L267
  222. magic-value-comparison:
    Consider using a named constant or an enum instead of 'None'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L267
  223. too-many-branches:
    Too many branches (17/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L218
  224. too-many-branches:
    Too many branches (14/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_template.py#L319
  225. too-complex:
    '_update_color' is too complex. The McCabe rating is 21
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L247
  226. too-complex:
    '_prepare_subscribe_topics' is too complex. The McCabe rating is 20
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L345
  227. too-complex:
    'async_turn_on' is too complex. The McCabe rating is 27
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L509
  228. too-many-instance-attributes:
    Too many instance attributes (21/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L180
  229. too-many-locals:
    Too many local variables (17/15)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L247
  230. too-many-try-statements:
    try clause contains 4 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L250
  231. too-many-try-statements:
    try clause contains 3 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L265
  232. too-many-try-statements:
    try clause contains 3 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L279
  233. too-many-try-statements:
    try clause contains 3 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L301
  234. too-many-branches:
    Too many branches (17/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L247
  235. too-many-statements:
    Too many statements (73/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L247
  236. magic-value-comparison:
    Consider using a named constant or an enum instead of 'ON'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L354
  237. magic-value-comparison:
    Consider using a named constant or an enum instead of 'OFF'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L356
  238. magic-value-comparison:
    Consider using a named constant or an enum instead of 'color'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L364
  239. magic-value-comparison:
    Consider using a named constant or an enum instead of 'color_mode'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L372
  240. too-many-try-statements:
    try clause contains 2 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L376
  241. too-many-try-statements:
    try clause contains 2 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L404
  242. too-many-branches:
    Too many branches (18/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L350
  243. consider-ternary-expression:
    Consider rewriting as a ternary expression
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L495
  244. too-many-locals:
    Too many local variables (16/15)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L509
  245. too-many-branches:
    Too many branches (27/12)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L509
  246. too-many-statements:
    Too many statements (105/50)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L509
  247. redefined-variable-type:
    Redefinition of self._attr_color_mode type from homeassistant.components.light.ColorMode.HS to homeassistant.components.light.ColorMode.RGB
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/mqtt/light/schema_json.py#L567
  248. magic-value-comparison:
    Consider using a named constant or an enum instead of 'clear'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/nws/weather.py#L72
  249. magic-value-comparison:
    Consider using a named constant or an enum instead of 'day'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/nws/weather.py#L73
  250. magic-value-comparison:
    Consider using a named constant or an enum instead of 'night'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/nws/weather.py#L75
  251. too-many-ancestors:
    Too many ancestors (8/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/nws/weather.py#L115
  252. too-many-instance-attributes:
    Too many instance attributes (12/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/nws/weather.py#L115
  253. consider-using-assignment-expr:
    Use 'if (wind_speed := forecast_entry.get('windSpeedAvg')) is not None:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/nws/weather.py#L302
  254. no-self-use:
    Method could be a function
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/nws/weather.py#L256
  255. consider-ternary-expression:
    Consider rewriting as a ternary expression
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/nws/weather.py#L335
  256. too-many-return-statements:
    Too many return statements (7/6)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/nws/sensor.py#L191
  257. consider-ternary-expression:
    Consider rewriting as a ternary expression
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/nws/sensor.py#L229
  258. line-too-long:
    Line too long (102/100)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L405
  259. line-too-long:
    Line too long (177/100)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L411
  260. too-many-instance-attributes:
    Too many instance attributes (15/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L134
  261. magic-value-comparison:
    Consider using a named constant or an enum instead of 'C'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L163
  262. redefined-variable-type:
    Redefinition of self._attr_temperature_unit type from homeassistant.const.UnitOfTemperature.FAHRENHEIT to homeassistant.const.UnitOfTemperature.CELSIUS
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L164
  263. magic-value-comparison:
    Consider using a named constant or an enum instead of 'emheat'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L304
  264. magic-value-comparison:
    Consider using a named constant or an enum instead of '2'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L314
  265. magic-value-comparison:
    Consider using a named constant or an enum instead of '2'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L314
  266. too-many-try-statements:
    try clause contains 8 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L320
  267. magic-value-comparison:
    Consider using a named constant or an enum instead of 'cool'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L344
  268. magic-value-comparison:
    Consider using a named constant or an enum instead of 'heat'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L346
  269. too-many-try-statements:
    try clause contains 4 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L359
  270. too-many-try-statements:
    try clause contains 4 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L395
  271. consider-using-assignment-expr:
    Use 'if (mode := self._device.system_mode) in HW_MODE_TO_HVAC_MODE:' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L419
  272. too-many-try-statements:
    try clause contains 4 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L420
  273. too-many-try-statements:
    try clause contains 2 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L439
  274. too-many-try-statements:
    try clause contains 2 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L468
  275. too-many-try-statements:
    try clause contains 2 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L478
  276. too-many-try-statements:
    try clause contains 3 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/honeywell/climate.py#L482
  277. consider-using-assignment-expr:
    Use 'if (today_sunshine_duration := getattr(self._device, 'todaySunshineDuration', None)):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/homematicip_cloud/binary_sensor.py#L387
  278. consider-using-assignment-expr:
    Use 'if (smoke_detector_at := getattr(self._device, 'smokeDetectorAlarmType', None)):' instead
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/homematicip_cloud/binary_sensor.py#L491
  279. use-implicit-booleaness-not-comparison-to-zero:
    "int(self._raw_state) != 0" can be simplified to "int(self._raw_state)", if it is strictly an int, as 0 is falsey
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/huawei_lte/binary_sensor.py#L216
  280. import-error:
    Unable to import 'gps3.agps3threaded'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/gpsd/sensor.py#L8
  281. import-error:
    Unable to import 'voluptuous'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/gpsd/sensor.py#L9
  282. too-many-try-statements:
    try clause contains 3 statements, expected at most 1
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/gpsd/sensor.py#L67
  283. unused-argument:
    Unused argument 'discovery_info'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/gpsd/sensor.py#L49
  284. magic-value-comparison:
    Consider using a named constant or an enum instead of '3'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/gpsd/sensor.py#L106
  285. magic-value-comparison:
    Consider using a named constant or an enum instead of '2'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/gpsd/sensor.py#L108
  286. too-many-ancestors:
    Too many ancestors (8/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/trafikverket_camera/binary_sensor.py#L59
  287. too-many-ancestors:
    Too many ancestors (8/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/trafikverket_camera/sensor.py#L99
  288. magic-value-comparison:
    Consider using a named constant or an enum instead of 'denonavr'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/alexa/entities.py#L714
  289. magic-value-comparison:
    Consider using a named constant or an enum instead of 'scene'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/alexa/entities.py#L733
  290. magic-value-comparison:
    Consider using a named constant or an enum instead of 'stream'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/alexa/entities.py#L972
  291. use-implicit-booleaness-not-comparison-to-zero:
    "segment != 0" can be simplified to "segment", if it is strictly an int, as 0 is falsey
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/wled/select.py#L151
  292. too-many-boolean-expressions:
    Too many boolean expressions in if statement (8/5)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/wled/update.py#L58
  293. locally-disabled:
    Locally disabling super-init-not-called (W0231)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/shelly/entity.py#L555
  294. locally-disabled:
    Locally disabling super-init-not-called (W0231)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/shelly/entity.py#L629
  295. suppressed-message:
    Suppressed 'super-init-not-called' (from line 555)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/shelly/entity.py#L555
  296. suppressed-message:
    Suppressed 'super-init-not-called' (from line 629)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/shelly/entity.py#L629
  297. locally-disabled:
    Locally disabling protected-access (W0212)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/vlc_telnet/media_player.py#L60
  298. too-complex:
    'async_update' is too complex. The McCabe rating is 15
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/vlc_telnet/media_player.py#L109
  299. import-error:
    Unable to import 'aiovlc.client'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/vlc_telnet/media_player.py#L8
  300. import-error:
    Unable to import 'aiovlc.exceptions'
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/vlc_telnet/media_player.py#L9
  301. too-many-instance-attributes:
    Too many instance attributes (16/7)
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e041adeab8451d2a57/homeassistant/components/vlc_telnet/media_player.py#L68
  302. magic-value-comparison:
    Consider using a named constant or an enum instead of 'playing'.
    https://github.com/home-assistant/core/blob/904913c1a6b0a89a979e97e0...

This comment was truncated because GitHub allows only 65536 characters in a comment.

This comment was generated for commit 83ade2f

@agusdmb
Copy link
Contributor Author

agusdmb commented Sep 12, 2023

Do you mean like running a mermaid parser to the output file?

Yeah, but I don't know if there is an easy way to do that. And there are other output formats too, none of which I personally use. I thought I had manually tested the output, but obviously not well enough!

Well I was just checking that, it seems that mermaid has exposed their parser mermaid-js/mermaid#4
I don't know how easy or hard might be too create a GitHub action with it

@Pierre-Sassoulas Pierre-Sassoulas added backport maintenance/3.3.x and removed Skip news πŸ”‡ This change does not require a changelog entry labels Sep 13, 2023
@Pierre-Sassoulas
Copy link
Member

Maybe we can fix the issue and backport it in 2.17.x and then later another MR for a long term solution to not introduce this kind of bugs ?

@agusdmb
Copy link
Contributor Author

agusdmb commented Sep 13, 2023

Maybe we can fix the issue and backport it in 2.17.x and then later another MR for a long term solution to not introduce this kind of bugs ?

this issue is not in version 2, got merged in #8824 directly into version 3

@Pierre-Sassoulas Pierre-Sassoulas added Unreleased Skip news πŸ”‡ This change does not require a changelog entry and removed backport maintenance/3.3.x labels Sep 13, 2023
@DudeNr33
Copy link
Collaborator

Thank you for the catch!
I agree that checking the output files for correctness would be a great improvement. This could and should be extended to the other output formats as well.

@DudeNr33 DudeNr33 merged commit 6d9b07d into pylint-dev:main Sep 16, 2023
@agusdmb agusdmb deleted the fix/mermaid-dot-arrow branch September 16, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DudeNr33 DudeNr33 DudeNr33 approved these changes

Assignees
No one assigned
Labels
Bug πŸͺ² pyreverse Related to pyreverse component Skip news πŸ”‡ This change does not require a changelog entry Unreleased
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid mermaid arrow
4 participants
@agusdmb @nickdrozd @Pierre-Sassoulas @DudeNr33