Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid mermaid arrow #9030

Closed
agusdmb opened this issue Sep 12, 2023 · 0 comments · Fixed by #9031
Closed

Invalid mermaid arrow #9030

agusdmb opened this issue Sep 12, 2023 · 0 comments · Fixed by #9031
Labels
Bug 🪲 Needs PR This issue is accepted, sufficiently specified and now needs an implementation pyreverse Related to pyreverse component Unreleased

Comments

@agusdmb
Copy link
Contributor

agusdmb commented Sep 12, 2023 

          This is not valid mermaid.

it should be:
mod_c ..> mod_a
as documented here:
https://mermaid.js.org/syntax/classDiagram.html#defining-relationship

github renders mermaid files, and if we try to open this one we get an error, see:
https://github.com/pylint-dev/pylint/blob/ffe1e714a3cfe83b5a627ade6d723489f2e10621/tests/pyreverse/functional/package_diagrams/type_check_imports/packages.mmd

Originally posted by @agusdmb in #8824 (comment)
@Pierre-Sassoulas Pierre-Sassoulas added pyreverse Related to pyreverse component Needs PR This issue is accepted, sufficiently specified and now needs an implementation Bug 🪲 labels Sep 12, 2023
@agusdmb agusdmb mentioned this issue Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🪲 Needs PR This issue is accepted, sufficiently specified and now needs an implementation pyreverse Related to pyreverse component Unreleased
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix mermaid dotted arrow agusdmb/pylint
2 participants
@Pierre-Sassoulas @agusdmb