-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with python 3.13.1 #2647
Conversation
|
02f6334
to
ab301db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ! I think the pylint job is expected to fail and I rerun the python 3.9 job that failed with a core dump due to solar flares
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
==========================================
- Coverage 93.20% 93.19% -0.01%
==========================================
Files 93 93
Lines 11077 11078 +1
==========================================
Hits 10324 10324
- Misses 753 754 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2647-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fe01bda8d9b3e118b1713f726dea6efffa0c6b07
# Push it to GitHub
git push --set-upstream origin backport-2647-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x Then, create a pull request where the |
Refs python/cpython#125415 (cherry picked from commit fe01bda)
Refs python/cpython#125415 (cherry picked from commit fe01bda)
@Pierre-Sassoulas Well, now I'm doubtful this accomplished anything because I'm having trouble reproducing the original issue. Ugh. I have no idea how to proceed. |
Should we create a brain for |
Well that's what I tried, but it didn't make a difference. At a loss until I can repro the problem. |
never mind, that job was running python 3.12 for some reason. back to square one. |
Type of Changes
Description
Refs python/cpython#125415
Closes pylint-dev/pylint#10112