Jnmpi lammps nodes patch 0.1.0 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do type checking when assigning to value now, so no need for a special method
Forget the "computational efficiency", just always type check. _But_ we should make it easier to disable _all_ type checking once users have a workflow they're totally satisfied with and want to run it in production.
Value validation
Bumps [matplotlib](https://github.com/matplotlib/matplotlib) from 3.8.0 to 3.8.1. - [Release notes](https://github.com/matplotlib/matplotlib/releases) - [Commits](matplotlib/matplotlib@v3.8.0...v3.8.1) --- updated-dependencies: - dependency-name: matplotlib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Including introducing new testing classes to directly test for promises made on the base class. In general, I want to head this direction in this PR: be as explicit as possible about the promises the classes make, and then test each of the promises as directly as possible.
Including testing each of the run boolean flags
Being running stops us from being ready, so we don't get all the way to the runtime error but stop at the readiness check
And move a bit more into the abstract node tests
Make py files node packages
Nodes for the `atomistics` package
Bumps [matplotlib](https://github.com/matplotlib/matplotlib) from 3.8.1 to 3.8.2. - [Release notes](https://github.com/matplotlib/matplotlib/releases) - [Commits](matplotlib/matplotlib@v3.8.1...v3.8.2) --- updated-dependencies: - dependency-name: matplotlib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pyiron-base](https://github.com/pyiron/pyiron_base) from 0.6.8 to 0.6.9. - [Release notes](https://github.com/pyiron/pyiron_base/releases) - [Changelog](https://github.com/pyiron/pyiron_base/blob/main/CHANGELOG.md) - [Commits](pyiron/pyiron_base@pyiron_base-0.6.8...pyiron_base-0.6.9) --- updated-dependencies: - dependency-name: pyiron-base dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pyiron-atomistics](https://github.com/pyiron/pyiron_atomistics) from 0.3.5 to 0.3.7. - [Release notes](https://github.com/pyiron/pyiron_atomistics/releases) - [Changelog](https://github.com/pyiron/pyiron_atomistics/blob/main/CHANGELOG.md) - [Commits](pyiron/pyiron_atomistics@pyiron_atomistics-0.3.5...pyiron_atomistics-0.3.7) --- updated-dependencies: - dependency-name: pyiron-atomistics dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
….3.7 Bump pyiron-atomistics from 0.3.5 to 0.3.7
Handle actions itself in the dependabot updates
# Conflicts: # .binder/environment.yml # notebooks/deepdive.ipynb
And rerun notebook
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
|
Change for this were super minor, just making ints into floats to comply with type hinting, so I'm going to merge without review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost no changes were needed to get the lammps nodes branch compliant with 0.1.0, just a couple of parameter changes from int to float to get values compliant with a type hint.