Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make py files node packages #79

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Make py files node packages #79

merged 2 commits into from
Nov 19, 2023

Conversation

liamhuber
Copy link
Member

This is just so we can Workflow.register these files; another PR changing the macros will follow.

@liamhuber
Add nodes: list[Node] attribute to the node packages
c248151 
This is necessary for the creator to register the packages, and allows us to _not_ expose nodes which are only in the file for internal use.
@github-actions GitHub Actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/make_py_files_node_packages

@liamhuber liamhuber changed the base branch from main to atomistics_library November 19, 2023 16:13
@liamhuber liamhuber added the format_black trigger the Black formatting bot label Nov 19, 2023
@liamhuber liamhuber marked this pull request as ready for review November 19, 2023 19:44
@liamhuber
Copy link
Member Author

@jan-janssen, since this is super minimal and strictly necessary for the registration, I'm going to merge it without review.

@liamhuber liamhuber merged commit 82f1b4b into atomistics_library Nov 19, 2023
12 of 13 checks passed
@liamhuber liamhuber deleted the make_py_files_node_packages branch November 19, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
format_black trigger the Black formatting bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamhuber @pyiron-runner