Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker: Use generator functions to reduce memory load #719

Closed
wants to merge 10 commits into from

Conversation

jan-janssen
Copy link
Member

No description provided.

@jan-janssen jan-janssen marked this pull request as draft March 10, 2022 00:26
@jan-janssen jan-janssen marked this pull request as ready for review March 10, 2022 20:27
@pmrv
Copy link
Contributor

pmrv commented Mar 10, 2022

We should find a way to check what is actually causing the memory increase. I cannot image that keeping the lists around that store the job ids actually cause a significant memory penalty unless your are submitted upwards of 1e9 jobs. My feeling is rather the we have a memory leak somewhere when running jobs and should look into this, maybe something like this old issue.

@jan-janssen
Copy link
Member Author

So my issue is that the worker runs into a memory issue when running with 510 jobs. I am not exactly sure if this is the main process of the worker or the sum of sub process. I looked into different spawn methods but that did not help. I also tried to only execute the executable in the subprocess #722 .

@jan-janssen jan-janssen added format_black reformat the code using the black standard labels Mar 14, 2022
@jan-janssen
Copy link
Member Author

File "D:\a\pyiron_base\pyiron_base\pyiron_base\job\worker.py", line 12, in <module>
[275](https://github.com/pyiron/pyiron_base/runs/5538617780?check_suite_focus=true#step:5:275)
    import resource
[276](https://github.com/pyiron/pyiron_base/runs/5538617780?check_suite_focus=true#step:5:276)
ModuleNotFoundError: No module named 'resource'

@jan-janssen jan-janssen requested a review from pmrv March 14, 2022 16:31
@jan-janssen
Copy link
Member Author

Unfortunately the resource package is unix specific https://docs.python.org/3/library/resource.html

@jan-janssen jan-janssen added format_black reformat the code using the black standard and removed format_black reformat the code using the black standard labels Mar 14, 2022
@stale
Copy link

stale bot commented Mar 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 29, 2022
@stale stale bot removed the stale label Mar 31, 2022
@jan-janssen jan-janssen added format_black reformat the code using the black standard and removed format_black reformat the code using the black standard labels Mar 31, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this Apr 30, 2022
@samwaseda samwaseda deleted the worker_generator2 branch November 2, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black reformat the code using the black standard stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants