Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not polute resource_path #453

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Do not polute resource_path #453

merged 2 commits into from
Dec 2, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Nov 30, 2021

Fixes #452

@pmrv pmrv added the bug Something isn't working label Nov 30, 2021
@coveralls
Copy link

coveralls commented Nov 30, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1527814219

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 69.825%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/lammps/potential.py 2 3 66.67%
Totals Coverage Status
Change from base Build 1526173852: -0.002%
Covered Lines: 11431
Relevant Lines: 16371
💛 - Coveralls

@liamhuber
Copy link
Member

@pmrv you're going to need to merge in master and resolve the conflicts (easy) -- I merged the state PR so s --> state.settings.

liamhuber
liamhuber approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the merge conflict (which I think github would anyhow force you to resolve) I'd say it's good to go.

@pmrv pmrv merged commit 3bc6e40 into master Dec 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the resource-mess branch December 2, 2021 09:16
@pmrv pmrv mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamhuber liamhuber liamhuber approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

s.resource_list sometimes grows without bounds
3 participants
@pmrv @coveralls @liamhuber