-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement enumerate_adapters
for rs-backend
#412
Conversation
enumerate_adapters
for rs-backend
70257cf
to
d2aa6eb
Compare
d2aa6eb
to
fed8c9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice!
The codegen sometimes makes refactorings like this a bit tricky. I added a comment for a way to work around this.
I'm not 100% sure about the API, relates to #410. But the solution you offer here - to make the user go into wgpu.backends.rs
- seems like a pretty good alternative. We'd have to figure out how to document this function though.
This also relates somewhat to #408. I propose that we move this PR forward and figure out the #401 stuff later.
Co-authored-by: Almar Klein <[email protected]>
FYI: The example for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! |
For the record, when #408 is merged, it will be |
I originally used wgpu with WebGPU, but recently I came across this library. As mentioned in #409, I also needed to choose an adapter to try out compute shaders, so I implemented it on a trial basis. I'm not sure if it conforms to your coding style, but I would appreciate it if you could review it. If you are already working on something similar, please feel free to close it as appropriate.
Resolves #409