-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Shadertoy Utility #401
Conversation
short update, I had encountered more panics and found a ways to catch them by doing more translations. Would it be okay to take all of that validation out (I will keep it in own project instead) and just add the offscreen and snapshot features with this PR for now? |
Yes, that sounds good! The glsl validation are present in the latest wgpu-native release, so they will be in wgpu-py in the next update. |
Thanks! |
picking up from #360
Several steps to this PR (will be updated)
validate shadercode (with naga?) before creating shader module(addressed by allow handling errors for spirv and glsl shader gfx-rs/wgpu-native#313)I welcome any feedback to my additions. I don't want to break any existing functionality.