Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "unit"-parameter to date_range, enhance iso time parser to us #9885

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Add "unit"-parameter to date_range, enhance iso time parser to us #9885

merged 7 commits into from
Dec 16, 2024
+69 −12

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer kmuehlbauer commented Dec 13, 2024 •
edited
Loading

  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@kmuehlbauer
Copy link
Contributor Author

kmuehlbauer commented Dec 13, 2024 •
edited
Loading

Not ready yet... Ready for review.

I didn't know xarray has a regex-based iso time parser. Always something new to learn...

@kmuehlbauer kmuehlbauer marked this pull request as ready for review December 14, 2024 16:32
@kmuehlbauer
Copy link
Contributor Author

As a follow-up to #9882 this makes the unit-kwarg available in xr.date_range which will be finally used in #9618. If there are no additional comments or change requests, I'm going to merge this the next day.

@kmuehlbauer kmuehlbauer added the plan to merge Final call for comments label Dec 16, 2024
@kmuehlbauer kmuehlbauer mentioned this pull request Dec 16, 2024
Open
9 tasks
dcherian
dcherian approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me.

@kmuehlbauer kmuehlbauer merged commit 7fd7daf into pydata:main Dec 16, 2024
35 checks passed
@kmuehlbauer kmuehlbauer deleted the unit-parameter branch December 16, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmuehlbauer @dcherian